1517052 - [raptor] Do not report power usage when raptor fails to report results

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Bob Clary [:bc] (inactive)]

The power tests show bimodal behavior with higher energy usage when raptor fails to report results. See Bug 1499253. I don't believe that these energy usage values are useful when raptor fails and will make it difficult to determine improvements or regressions in energy usage.

We should not report energy PERFHERDER_DATA when raptor fails to report results.

rwood: Do you think you could take this? You know the results reporting in raptor much better than I do.

Comment 1

[Robert Wood [:rwood]]

Thanks :bc makes sense, yep I'll take this.

Comment 2

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c16c89d2f226b2157b243f8e0bd3bdbead2d376e

Comment 3

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4ee6eec0f0434e523516a97d4bbc137aba8c9b2

Comment 4

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90c88eabe7cc96951bd1d4fdd20735955ece7997

Comment 5

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #4)

> https://treeherder.mozilla.org/#/jobs?repo=try&revision=90c88eabe7cc96951bd1d4fdd20735955ece7997

In that try push ^ I temporarily reduced the Raptor speedometer geckoview timeout, to force the speedometer test to fail. Looks good - the power measurements were gathered successfully but not dumped to Perfherder since the actual speedometer test itself failed to complete.

Comment 6

[Robert Wood [:rwood]]

Attachment: Bug 1517052 - [raptor] Do not report power usage when raptor fails to report results; r?jmaher,davehunt

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7627e62b3833
[raptor] Do not report power usage when raptor fails to report results; r=jmaher

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7627e62b3833