Closed Bug 1517232 Opened 2 years ago Closed 2 years ago

Remove the gonk reference

Categories

(NSPR :: NSPR, enhancement)

Product:
NSPR
Component:
NSPR
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

gonk.diff
5.28 KB, patch
ted
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch gonk.diff — — Splinter Review
Attachment #9033942 - Flags: review?(core-build-config-reviews)
Comment on attachment 9033942 [details] [diff] [review]
gonk.diff

Review of attachment 9033942 [details] [diff] [review]:
-----------------------------------------------------------------

configure{,.in} doesn't exist in the tree in the format you've diffed against here...
Attachment #9033942 - Flags: review?(core-build-config-reviews)
Comment on attachment 9033942 [details] [diff] [review]
gonk.diff

Nathan didn't realized that it was about nspr.
And suggested that Ted is a better review than the build per group
Attachment #9033942 - Flags: review?(ted)
Comment on attachment 9033942 [details] [diff] [review]
gonk.diff

Review of attachment 9033942 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine but I don't know that it's worth the hassle, honestly.
Attachment #9033942 - Flags: review?(ted) → review+
Target Milestone: --- → 4.21
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1526010
You need to log in before you can comment on or make changes to this bug.