Remove the gonk reference

RESOLVED FIXED in 4.21

Status

Product:
NSPR
Component:
NSPR
Type:
enhancement
Status:
RESOLVED FIXED
Reported:
5 months ago
Modified:
4 months ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks 1 bug)

Version:
other
Target:
4.21
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

gonk.diff
5.28 KB, patch
ted
: review+
Details | Diff | Splinter Review
Assignee

Description

•
5 months ago 
No description provided.
Assignee

Comment 1

•
5 months ago
Posted patch gonk.diff — — Splinter Review
Attachment #9033942 - Flags: review?(core-build-config-reviews)

Comment 2

•
5 months ago 
Comment on attachment 9033942 [details] [diff] [review]
gonk.diff

Review of attachment 9033942 [details] [diff] [review]:
-----------------------------------------------------------------

configure{,.in} doesn't exist in the tree in the format you've diffed against here...
Attachment #9033942 - Flags: review?(core-build-config-reviews)
Assignee

Comment 3

•
5 months ago 
Comment on attachment 9033942 [details] [diff] [review]
gonk.diff

Nathan didn't realized that it was about nspr.
And suggested that Ted is a better review than the build per group
Attachment #9033942 - Flags: review?(ted)

Comment 4

•
5 months ago 
Comment on attachment 9033942 [details] [diff] [review]
gonk.diff

Review of attachment 9033942 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine but I don't know that it's worth the hassle, honestly.
Attachment #9033942 - Flags: review?(ted) → review+

Updated

•
4 months ago
Target Milestone: --- → 4.21

Updated

•
4 months ago
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED

Updated

•
4 months ago
Blocks: 1526010
You need to log in before you can comment on or make changes to this bug.