Closed Bug 1517307 Opened 2 years ago Closed 2 years ago

Convert resetProfile.dtd to Fluent

Categories

(Toolkit :: General, enhancement, P3)

64 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jaws, Assigned: chenbri2, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

resetProfile.dtd is referenced by safeMode.xul, aboutSupport.xhtml, resetProfile.xul, and resetProfileProgress.xul.

Converting resetProfile.dtd to Fluent will allow aboutSupport.xhtml to remove the dependency on brand.dtd as well, as resetProfile.dtd is the only part of aboutSupport.xhtml that depends on brand.dtd.
Priority: -- → P3

The safe mode case might actually make this tricky - we should make sure to check it. I expect we'll need to move this block of code:

https://searchfox.org/mozilla-central/rev/b4ebbe90ae4d0468fe6232bb4ce90699738c8125/browser/components/nsBrowserGlue.js#1084-1090

to before we show the dialog (a few lines earlier in that function).

Assignee: nobody → chenbri2
Status: NEW → ASSIGNED

Convert resetProfile.dtd to resetProfile.ftl. Modify dependencies for resetProfile.xul, safeMode.xul, aboutSupport.xhtml, resetProfileProgress.xul.
Currently resetProfile.xul does not properly display reset-profile-button. Migration script needs to be edited.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68f9119eacf5
Convert resetProfile.dtd to Fluent r=jaws,flod
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Duplicate of this bug: 1525110
Regressions: 1600919
You need to log in before you can comment on or make changes to this bug.