Closed Bug 1517442 Opened 10 months ago Closed 9 months ago

"raise_for_port" should not use DEFAULT_STARTUP_TIMEOUT but self.startup_timeout if timeout is None

Categories

(Testing :: Marionette, defect, P3)

defect

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: whimboo, Assigned: agboolaolamide9, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=py])

User Story

Please read the following document in how to get started:

https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html

Attachments

(1 file)

The startup timeout can be customized via an command line argument, and gets set in Marionette client here:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/testing/marionette/client/marionette_driver/marionette.py#624-627

Later `raise_for_port` doesn't care about it, and simply uses the default value instead:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/testing/marionette/client/marionette_driver/marionette.py#700-701

Lets change that so the custom value is used.
Priority: -- → P3

Hi @whimboo, I'm new to open source and would like to work on this issue

Hello Agboola. Feel welcome to our community! I'm looking forward to work with you.

To get started please check the link in the user story above. It contains all the information to get you started. Let me know if there is something unclear. You can ask here, or better connect to our IRC channel (all described in the documentation).

Once the first version of the patch has been uploaded I will mark the bug as assigned to you.

Change raise_for_port from self.DEFAULT_STARTUP_TIMEOUT to self.startup_timeout if timeout is None
Attachment #9036732 - Attachment description: Bug 1517442 - Change raise_for_port to use self.startup_timeout if timeout is None → Bug 1517442 - Use current instead of default startup time in raise_for_port
Attachment #9036732 - Attachment description: Bug 1517442 - Use current instead of default startup time in raise_for_port → Bug 1517442 - [marionette] Use current instead of default startup time in raise_for_port
Assignee: nobody → agboolaolamide9
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0e6b3cbbd16
[marionette] Use current instead of default startup time in raise_for_port r=whimboo
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.