1517442 - "raise_for_port" should not use DEFAULT_STARTUP_TIMEOUT but self.startup_timeout if timeout is None

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The startup timeout can be customized via an command line argument, and gets set in Marionette client here:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/testing/marionette/client/marionette_driver/marionette.py#624-627

Later `raise_for_port` doesn't care about it, and simply uses the default value instead:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/testing/marionette/client/marionette_driver/marionette.py#700-701

Lets change that so the custom value is used.

Comment 1

[Agboola Mukhtar <agbo-ola>]

Hi @whimboo, I'm new to open source and would like to work on this issue

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hello Agboola. Feel welcome to our community! I'm looking forward to work with you.

To get started please check the link in the user story above. It contains all the information to get you started. Let me know if there is something unclear. You can ask here, or better connect to our IRC channel (all described in the documentation).

Once the first version of the patch has been uploaded I will mark the bug as assigned to you.

Comment 3

[Agboola Mukhtar <agbo-ola>]

Attachment: Bug 1517442 - [marionette] Use current instead of default startup time in raise_for_port

Change raise_for_port from self.DEFAULT_STARTUP_TIMEOUT to self.startup_timeout if timeout is None

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e6b3cbbd16
[marionette] Use current instead of default startup time in raise_for_port r=whimboo

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d0e6b3cbbd16