1517478 - Crash in nsQueryReferent::operator() in nsWeakReference, address 0X0 with autoarchive add-on

Status: RESOLVED INCOMPLETE

(MailNews Core :: Networking: IMAP, defect)

Description

[Moritz Naumann]

This bug was filed from the Socorro interface and is
report bp-819ac12f-2c80-4695-8d45-9a9220190103.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so nsQueryReferent::operator /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/base/nsWeakReference.cpp:152
1 libxul.so nsCOMPtr_base::assign_from_query_referent /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/base/nsCOMPtr.cpp:117
2 libxul.so nsMsgSearchSession::TimerCallback /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/base/nsCOMPtr.h:595
3 libxul.so nsTimerImpl::Fire /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/threads/nsTimerImpl.cpp:701
4 memfd:pulseaudio (deleted) memfd:pulseaudio @0xa711fff 
5 libc-2.27.so libc-2.27.so@0x130ea5 
6 libxul.so nsTimerEvent::Run /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/threads/TimerThread.cpp:286
7 libxul.so mozilla::HangMonitor::NotifyActivity /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/threads/HangMonitor.cpp:405
8 libxul.so nsThread::ProcessNextEvent /build/thunderbird-Z9Pyl0/thunderbird-60.2.1+build1/xpcom/threads/nsThread.cpp:1040
9 libpthread-2.27.so libpthread-2.27.so@0xb7de 

=============================================================

Note from bug submitter:

https://crash-stats.mozilla.com/report/index/819ac12f-2c80-4695-8d45-9a9220190103

This is triggered by selecting the "AutoArchive Now..." function in the "Tools" menu, as provided by the "AutoArchive Now..." add-on. The crash, obviously, affects all of Thunderbird, though. This is TB 60.2.1 (64-bit), as shipped by Ubuntu 18.04 LTS.

Comment 1

[Moritz Naumann]

AutoarchiveReloaded add-on issue (FYI only) https://github.com/Brummolix/AutoarchiveReloaded/issues/28

Comment 2

[Wayne Mery (:wsmwk)]

Does this reproduce without other addons loaded and newer Thunderbird?

Is it known whether autoarchive works with Thunderbird beta?

https://www.thunderbird.net/en-US/channel/
https://addons.thunderbird.net/en-US/thunderbird/addon/autoarchivereloaded/

Comment 3

[Moritz Naumann]

Sorry Wayne, I stopped using AutoArchiveReloaded since it was not working well for me, since there was no feedback to my bug report, and since I could not have it trigger bugs in Thunderbird.

Comment 4

[Wayne Mery (:wsmwk)]

with pulseaudio on your crash's stack, you might try again with audio disabled. (although I did not find any other crashes with pulseaudio on the stack)

You might also try awsomeautoarchive, which interestingly also has at least one crash bp-25e7147c-53f5-492d-af78-f39400190424 52.5.2
https://addons.thunderbird.net/en-US/thunderbird/addon/awesome-auto-archive/

Some other AutoArchiveReloaded crashes...
bp-1454afbe-bbdf-4344-84af-c4c170190405 52.8.0
bp-8eb48eb1-0fc4-4542-8832-4a3520190415 52.4.0
bp-a6f829ef-1e85-4557-ac00-223b90190411 60.6.1
bp-9c4b5429-cbec-491f-abf2-b407a0190207 60.4.0 linux
bp-819ac12f-2c80-4695-8d45-9a9220190103 60.2.1

Note, most crashes with this signature don't have either addon installed, so may be generic imap

Comment 5

[Moritz Naumann]

Thanks for those hints, Wayne. Indeed, AwesomeAutoArchive is what I'm using now. Unfortunately the latest version isn't published on AMO, but needed ( so I installed it from https://github.com/wangvisual/autoarchive/issues/107 ).

It's a pity that there is no proper archiving system in Thunderbird itself - this would make a good addition IMO.

Anyways, this is now bordering chatter, so I'll wrap it up here: Thanks for your time!

Comment 6

[Wayne Mery (:wsmwk)]

benc or geoff, any thoughts what we or the add-on author can do? ref: comment 4

Comment 7

[Ben Campbell]

I'd pick nsMsgSearchSession::TimerCallback() as the place to set my breakpoints, but nothing there really leaps out...
When I get a chance, I'll try installing AutoArchiveReloaded and see if I can catch it happening in the debugger.

Comment 8

[Geoff Lankow (:darktrojan)]

This really isn't my area, so I'll leave you to it, Ben.

Comment 9

[Wayne Mery (:wsmwk)]

https://github.com/Brummolix/AutoarchiveReloaded/issues/28#issuecomment-522348464 suggests there is extended logging in the add-on that might help

Comment 10

[Moritz Naumann]

I had provided those logs to the extension developer at https://github.com/Brummolix/AutoarchiveReloaded/issues/28#issuecomment-522756723 - who had swiftly provided his analysis. The ball is in Mozilla's field.

Comment 11

[Wayne Mery (:wsmwk)]

so https://github.com/Brummolix/AutoarchiveReloaded/issues/28#issuecomment-522771375

@wsmwk
The code of add on 0.9.9.6.2 is at https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js

The last log entry is https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js#L297
As no other log entry was written the crash might be raised from any of the following:

mail3PaneWindow.gFolderDisplay.show(folderToSelect);
https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js#L300
batchMover.archiveMessages(this.messages); (containing the list of >8000 messages)
https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js#L310
one of the things in the complete stopAndSetFinal function
https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js#L209
could be also in the checkForArchiveDone function as this is fired every 500ms
https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js#L548
or it could be also in some of the catch blocks AutoarchiveReloadedOverlay.Logger.errorException(e);
like https://github.com/Brummolix/AutoarchiveReloaded/blob/0.9.9.6.2/chrome/content/overlay.js#L315
I hope this analysis may help a bit.

Comment 12

[Wayne Mery (:wsmwk)]

I updated comment 11.

There does not appear to be a version 78 compatible version of autoarchive

Comment 13

[Wayne Mery (:wsmwk)]

Not actionable as is.

Comment 14

[brummolix]

Of course there is a compatible version of AutoarchiveReloaded, see https://addons.thunderbird.net/de/thunderbird/addon/autoarchivereloaded/
Original (typescript) code is under https://github.com/Brummolix/AutoarchiveReloaded

Did you mixed it up with the (really old) original Autoarchive https://addons.thunderbird.net/de/thunderbird/addon/autoarchive/ ?