1517505 - Remove app/feature and bootstrap exceptions from all_files_referenced test

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P2)

Description

[:Gijs (away/busy until Mar 10)]

This block of code:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#758-773

and this block:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#345-351

can be removed now that we no longer have features/ .

Comment 1

[:Gijs (away/busy until Mar 10)]

We can also remove:

https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#683-685

Comment 2

[Andrew Swan [:aswan]]

To be pedantic, we still have features/, but it no longer holds bootstrapped extensions and webextensions are handled in a different way (sigh).  But while we're here, I think the code in that test for handling chrome.manifest files can also go now:
https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#269-301

Comment 3

[:Gijs (away/busy until Mar 10)]

(Hiding Andrew's comment per IRC discussion. :-) )

Comment 4

[Dhyey Thakore [:dhyey35]]

Hi Gijs, I have setup mozilla-unified on my local machine and would like to contribute by fixing this bug. As I understand I just have to remove the 3 snippets of code you have linked. Also is the IRC Channel #firefox ?

Comment 5

[:Gijs (away/busy until Mar 10)]

(In reply to dhyey35 from comment #4)
> Hi Gijs, I have setup mozilla-unified on my local machine and would like to
> contribute by fixing this bug.

Great!

> As I understand I just have to remove the 3
> snippets of code you have linked.

Yep, that should be sufficient.

> Also is the IRC Channel #firefox ?

Probably best to use #fx-team or #developers if you have questions about this patch, or ask in this bug (you can use the "need more information" field to poke me directly, though I might be less responsive over the weekend).

Comment 6

[Dhyey Thakore [:dhyey35]]

Attachment: Bug 1517505 - Remove app/feature and bootstrap exceptions from all_files_referenced test

Comment 7

[Dhyey Thakore [:dhyey35]]

I have made the changes and submitted patch to Phabricator for review: https://phabricator.services.mozilla.com/D15783

Please let me know if anything else is required.

Comment 8

[:Gijs (away/busy until Mar 10)]

(In reply to dhyey35 from comment #7)
> I have made the changes and submitted patch to Phabricator for review:
> https://phabricator.services.mozilla.com/D15783
> 
> Please let me know if anything else is required.

Excellent, thanks!

For next time, you'll want to make sure you include a reviewer in the commit message (r?<Name-of-reviewer>), then phab automatically asks for review. I've updated the phab commit for you; just waiting for try to confirm that this change is OK - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d1a2ff6f04fb967fd972a10dbef3095b7752ae5 .

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bc15d28e6ec
Remove app/feature and bootstrap exceptions from all_files_referenced test r=Gijs

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6bc15d28e6ec

Comment 11

[Dhyey Thakore [:dhyey35]]

You're welcome :)
Sure I will take care from next time about reviewer's name in the commit.