Closed
Bug 1517505
Opened 5 years ago
Closed 5 years ago
Remove app/feature and bootstrap exceptions from all_files_referenced test
Categories
(Firefox :: General, enhancement, P2)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: Gijs, Assigned: dhyey35, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
This block of code: https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#758-773 and this block: https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#345-351 can be removed now that we no longer have features/ .
Reporter | ||
Comment 1•5 years ago
|
||
We can also remove: https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/test/static/browser_all_files_referenced.js#683-685
Summary: Remove app/feature exceptions from all_files_referenced test → Remove app/feature and bootstrap exceptions from all_files_referenced test
Comment hidden (obsolete) |
Reporter | ||
Comment 3•5 years ago
|
||
(Hiding Andrew's comment per IRC discussion. :-) )
Assignee | ||
Comment 4•5 years ago
|
||
Hi Gijs, I have setup mozilla-unified on my local machine and would like to contribute by fixing this bug. As I understand I just have to remove the 3 snippets of code you have linked. Also is the IRC Channel #firefox ?
Reporter | ||
Comment 5•5 years ago
|
||
(In reply to dhyey35 from comment #4) > Hi Gijs, I have setup mozilla-unified on my local machine and would like to > contribute by fixing this bug. Great! > As I understand I just have to remove the 3 > snippets of code you have linked. Yep, that should be sufficient. > Also is the IRC Channel #firefox ? Probably best to use #fx-team or #developers if you have questions about this patch, or ask in this bug (you can use the "need more information" field to poke me directly, though I might be less responsive over the weekend).
Mentor: gijskruitbosch+bugs
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
I have made the changes and submitted patch to Phabricator for review: https://phabricator.services.mozilla.com/D15783 Please let me know if anything else is required.
Flags: needinfo?(gijskruitbosch+bugs)
Reporter | ||
Comment 8•5 years ago
|
||
(In reply to dhyey35 from comment #7) > I have made the changes and submitted patch to Phabricator for review: > https://phabricator.services.mozilla.com/D15783 > > Please let me know if anything else is required. Excellent, thanks! For next time, you'll want to make sure you include a reviewer in the commit message (r?<Name-of-reviewer>), then phab automatically asks for review. I've updated the phab commit for you; just waiting for try to confirm that this change is OK - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d1a2ff6f04fb967fd972a10dbef3095b7752ae5 .
Assignee: nobody → dhyey35
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Updated•5 years ago
|
Priority: -- → P2
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6bc15d28e6ec Remove app/feature and bootstrap exceptions from all_files_referenced test r=Gijs
Comment 10•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee | ||
Comment 11•5 years ago
|
||
You're welcome :)
Sure I will take care from next time about reviewer's name in the commit.
You need to log in
before you can comment on or make changes to this bug.
Description
•