"WebDriver:SetWindowRect" should not return window state

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

As decided during the last TPAC meeting the "Set Window Rect" command should only return the window rect, but not the window state. But as noticed in recent log files Marionette (but not geckodriver) returns it.

[task 2019-01-03T18:53:48.691Z] 18:53:48     INFO - PID 30263 | 1546541628639	Marionette	DEBUG	0 -> [0,102,"WebDriver:SetWindowRect",{"height":600,"width":800}]
[task 2019-01-03T18:53:48.692Z] 18:53:48     INFO - PID 30263 | 1546541628643	Marionette	DEBUG	0 <- [1,102,null,{"x":0,"y":0,"width":800,"height":600,"state":"normal"}]
[task 2019-01-03T18:53:48.693Z] 18:53:48     INFO - PID 30263 | 1546541628643	webdriver::server	DEBUG	<- 200 OK {"value":{"x":0,"y":0,"width":800,"height":600}}

It would be good to get this extra field removed.
The upcoming patch will also remove the Marionette test test_minimized.py because both of the tests are covered by Wdspec tests now.
As decided during the last TPAC meeting the window rect commands
should not return the window state.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f465582eb8c
[marionette] Get/Set Window Rect should not return window state. r=ato
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=1f465582eb8c486fc9b2ba3cc140eafa9df9d1f9&tochange=6ff27f273550168fa5dab4b1fd78813a259820c8&selectedJob=219963223

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219963223&repo=autoland&lineNumber=1633

Backout link: https://hg.mozilla.org/integration/autoland/rev/6ff27f273550168fa5dab4b1fd78813a259820c8

[task 2019-01-04T13:40:08.586Z] 13:40:08     INFO -  Creating config.status
[task 2019-01-04T13:40:08.727Z] 13:40:08     INFO -  Reticulating splines...
[task 2019-01-04T13:40:10.254Z] 13:40:10     INFO -   0:01.55 File already read. Skipping: /builds/worker/workspace/build/src/gfx/angle/targets/angle_common/moz.build
[task 2019-01-04T13:40:13.747Z] 13:40:13    ERROR -  Traceback (most recent call last):
[task 2019-01-04T13:40:13.747Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/configure.py", line 123, in <module>
[task 2019-01-04T13:40:13.747Z] 13:40:13     INFO -      sys.exit(main(sys.argv))
[task 2019-01-04T13:40:13.748Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/configure.py", line 34, in main
[task 2019-01-04T13:40:13.748Z] 13:40:13     INFO -      return config_status(config)
[task 2019-01-04T13:40:13.748Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/configure.py", line 118, in config_status
[task 2019-01-04T13:40:13.748Z] 13:40:13     INFO -      return config_status(args=[], **encode(sanitized_config, encoding))
[task 2019-01-04T13:40:13.748Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/config_status.py", line 143, in config_status
[task 2019-01-04T13:40:13.748Z] 13:40:13     INFO -      definitions = list(definitions)
[task 2019-01-04T13:40:13.749Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/emitter.py", line 184, in emit
[task 2019-01-04T13:40:13.749Z] 13:40:13     INFO -      objs = list(emitfn(out))
[task 2019-01-04T13:40:13.752Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/emitter.py", line 1316, in emit_from_context
[task 2019-01-04T13:40:13.752Z] 13:40:13     INFO -      for obj in self._process_test_manifests(context):
[task 2019-01-04T13:40:13.752Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/emitter.py", line 1450, in _process_test_manifests
[task 2019-01-04T13:40:13.752Z] 13:40:13     INFO -      for obj in self._process_test_manifest(context, info, path, manifest):
[task 2019-01-04T13:40:13.752Z] 13:40:13     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/frontend/emitter.py", line 1558, in _process_test_manifest
[task 2019-01-04T13:40:13.752Z] 13:40:13     INFO -      context)
[task 2019-01-04T13:40:13.753Z] 13:40:13     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2019-01-04T13:40:13.753Z] 13:40:13     INFO -  ==============================
[task 2019-01-04T13:40:13.753Z] 13:40:13     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
Flags: needinfo?(hskupin)
Sorry, I missed to remove the test file from the manifest file.
Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13be012a1bae
[marionette] Get/Set Window Rect should not return window state. r=ato
https://hg.mozilla.org/mozilla-central/rev/13be012a1bae
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.