151770 - Can't associate Mozilla with .XBM images

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Now that bug 8031 has been fixed Mozilla can display XBM images but you can't
actually associate them with Mozilla in the advanced system pref panel.

Comment 1

[Aaron Kaluszka]

Attachment: Patch (untested)

I have not tested the patch, but I based it on
http://bugzilla.mozilla.org/attachment.cgi?id=67542&action=view so it should
work unless there's a reference that has changed somewhere that I don't know
about.
I gave XBM the accelerator key of 'A' since every other letter in "X BitMap"
was already used for something else.

Comment 2

[Aaron Kaluszka]

Heikki, can you look this over since I based my patch on an old one of yours?

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I don't know this code, I just changed all the places that seemed to need
changes (I searched with LXR for the XUL case and changed every place to accept
XHTML as well). Look who reviewed my changes (I think it might have been Bill
Law at least) and ask them to review.

Just looking at the patch itself it seems good, but I did not look at the
context around the changes or if you got all the instances that needed changes.
Also please test before you ask for reviews ;)

Comment 4

[Aaron Kaluszka]

Bill, I tested this patch and it seems to work, can you make sure I didn't miss
anything?

Comment 5

[Bill Law]

The code looks OK.  I'd like to make sure sufficient testing was done.  The
testing should include:

1. Making sure checkbox appears on Advanced/System pref pane.
2. Said checkbox appears properly checked/unchecked based on previous setting.
3. Registry entries are modified/restored properly when checkbox is
checked/unchecked (verified using regedit or equivalent).
4. A .xbm file opened on desktop launches Mozilla when the checkbox is checked,
doesn't when it is unchecked.
5. Manually zapping the registry entries when the checkbox is checked results in
the "default browser" alert popping up when Mozilla is launched.

Can you verify that you tried all these cases and it works correctly?

Comment 6

[Paul Wyskoczka]

qa --> [e-mail]

Comment 7

[Paul Wyskoczka]

adding nsbeta1- per nav triage team

Comment 8

[Aaron Kaluszka]

Attachment: Patch (tested)

The previous patch actually does work with all tests, but I noticed that IE
registers "xbmfile," so I added that to this patch.  Ready for review.

Comment 9

[Bill Law]

Comment on attachment 88198 [details] [diff] [review]
Patch (tested)

r=law

Comment 10

[Alec Flett]

Comment on attachment 88198 [details] [diff] [review]
Patch (tested)

sr=alecf

Comment 11

[Aaron Kaluszka]

Bill, can you check this in, I don't have CVS write access.  Also, do you see a
problem with asking for approval for 1.0.1?

Comment 12

[Samir Gehani]

-> law for checkin

Comment 13

[Scott Collins]

Comment on attachment 88198 [details] [diff] [review]
Patch (tested)

a=scc for checkin to the mozilla trunk

Comment 14

[[e-mail]]

Fix was checked in by timeless.