Closed
Bug 1517726
Opened 2 years ago
Closed 2 years ago
promptToChangePasswordWithUsernames references invalid "selectedLogin.userNameField" (incorrect case)
Categories
(Toolkit :: Password Manager, defect, P5)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: standard8, Assigned: plawless, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, regression, Whiteboard: [lang=js])
Attachments
(1 file)
This was introduced by bug 1243729: newLoginWithUsername.init(aNewLogin.hostname, aNewLogin.formSubmitURL, aNewLogin.httpRealm, selectedLogin.username, aNewLogin.password, selectedLogin.userNameField, aNewLogin.passwordField); `selectedLogin.userNameField` should be `selectedLogin.usernameField`, as the former isn't defined anywhere: https://searchfox.org/mozilla-central/search?q=userNameField&case=true®exp=false&path= Not sure if this would have any user-facing effects.
Flags: needinfo?(timdream)
Updated•2 years ago
|
Blocks: coverity-analysis
Keywords: coverity
Comment 1•2 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #0) > Not sure if this would have any user-facing effects. It won't because `usernameField` is never used.
Priority: -- → P5
Updated•2 years ago
|
Mentor: timdream
Flags: needinfo?(timdream)
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → plawless
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•2 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/bb5d37aec5da Corrected case of usernameField. r=MattN
Comment 5•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•