Closed Bug 1517726 Opened 9 months ago Closed 8 months ago
To Change Password With Usernames references invalid "selected Login .user Name Field" (incorrect case)
47 bytes, text/x-phabricator-request
|Details | Review|
This was introduced by bug 1243729: newLoginWithUsername.init(aNewLogin.hostname, aNewLogin.formSubmitURL, aNewLogin.httpRealm, selectedLogin.username, aNewLogin.password, selectedLogin.userNameField, aNewLogin.passwordField); `selectedLogin.userNameField` should be `selectedLogin.usernameField`, as the former isn't defined anywhere: https://searchfox.org/mozilla-central/search?q=userNameField&case=true®exp=false&path= Not sure if this would have any user-facing effects.
(In reply to Mark Banner (:standard8) from comment #0) > Not sure if this would have any user-facing effects. It won't because `usernameField` is never used.
Priority: -- → P5
Ah thanks for the clarification.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/bb5d37aec5da Corrected case of usernameField. r=MattN
You need to log in before you can comment on or make changes to this bug.