1517726 - promptToChangePasswordWithUsernames references invalid "selectedLogin.userNameField" (incorrect case)

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P5)

Description

[Mark Banner (:standard8)]

This was introduced by bug 1243729:

newLoginWithUsername.init(aNewLogin.hostname,
                          aNewLogin.formSubmitURL, aNewLogin.httpRealm,
                          selectedLogin.username, aNewLogin.password,
                          selectedLogin.userNameField, aNewLogin.passwordField);

`selectedLogin.userNameField` should be `selectedLogin.usernameField`, as the former isn't defined anywhere:

https://searchfox.org/mozilla-central/search?q=userNameField&case=true&regexp=false&path=

Not sure if this would have any user-facing effects.

Comment 1

[Matthew N. [:MattN]]

(In reply to Mark Banner (:standard8) from comment #0)
> Not sure if this would have any user-facing effects.

It won't because `usernameField` is never used.

Comment 2

[Mark Banner (:standard8)]

Ah thanks for the clarification.

Comment 3

[Patricia Lawless]

Attachment: Bug 1517726 - Corrected case of usernameField. r=MattN

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb5d37aec5da
Corrected case of usernameField. r=MattN

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/bb5d37aec5da