1517741 - If the 2nd Search bar is enabled, pressing the Tab key after clicking the in-content search bar will move the focus to it

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

[Affected versions]:
- Nightly 66.0a1 Build ID - 20190103220533

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a new Firefox profile.
- The 2nd search bar is added to the toolbar from about:preferences#search

[Steps to reproduce]:
1. Open the browser and navigate to about:newtab.
2. Click the in-content search bar.
3. Press the "Tab" key and observe the behavior.
 
[Expected result]:
- The focus is moved to the Top Sites section menu button.

[Actual result]:
- The focus is shifted to the 2nd address bar from the browser's toolbar.

[Notes]:
- This will be very unusual for users who are used to navigate the page with tab browsing as the behavior will differ greatly from what they are used to.
- There is another focused state that the in-content search bar can be in and this will only add to the confusion.
- Attached a screen recording of the issue: https://goo.gl/aETDiu

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I discussed with UX (Aaron and Bryan). This is a pretty low priority bug. => Backlog

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

This will be fixed by the patch for Bug 1520449

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Moving back to the backlog. We'll be going back to the hiddenFocus() approach so this issue will still exist. I guess maybe we can get tricky listening for TAB keydown as first keystroke into awesomebar and then refocus page at the right spot? icky