Closed Bug 1517750 Opened 6 years ago Closed 4 years ago

Invalid width/height on img tag in ReturnToAMO component

Categories

(Firefox :: Messaging System, defect, P5)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: andreio, Unassigned)

References

Details

Per PR #4578 (https://github.com/mozilla/activity-stream/pull/4578) and the https://html5.validator.nu/ HTML 5 validator, the `width` and `height` attributes appear to be invalid on the `<img>` tag (unless it's a React thing). The values should just be numeric in HTML (no "px" suffix, since that's a CSS only thing): https://github.com/mozilla/activity-stream/blob/f40d201cfe4d67fec4ba7adc10d46c4c97924af6/content-src/asrouter/templates/ReturnToAMO/ReturnToAMO.jsx#L27 Moved from https://github.com/mozilla/activity-stream/issues/4598#issue-392318354
Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P3
Iteration: 67.1 - Jan 28 - Feb 10 → 67.2 - Feb 11 - 24
Iteration: 67.2 - Feb 11 - 24 → ---
Component: Activity Streams: Newtab → Messaging System
Priority: P3 → P5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.