1517752 - Update to Cranelift 0.26

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

The API has slightly changed, so this is just a bit more than a ./mach vendor rust.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.patch

Functional changes. Second patch will come with the result of mach vendor rust,  both patches should be fused before landing.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.patch

can haz rubberstamp plz

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 3.patch

cargo +stable fmt (I'll merge this with the patch too)

Comment 4

[Dan Gohman [:sunfish]]

Comment on attachment 9034413 [details] [diff] [review]
1.patch

Review of attachment 9034413 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good!

Comment 5

[Dan Gohman [:sunfish]]

Comment on attachment 9034414 [details] [diff] [review]
2.patch

Review of attachment 9034414 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 6

[Dan Gohman [:sunfish]]

Comment on attachment 9034419 [details] [diff] [review]
3.patch

Review of attachment 9034419 [details] [diff] [review]:
-----------------------------------------------------------------

Happily, it seems like the changes get smaller each rustfmt release, so it seems to be starting to settle in :-).

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: folded.patch

Folded in patch, carrying forward r+ from Dan.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a4aab87dc85
Update to Cranelift 0.26; r=sunfish

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9a4aab87dc85