Closed Bug 1517752 Opened 11 months ago Closed 11 months ago

Update to Cranelift 0.26

Categories

(Core :: Javascript: WebAssembly, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

The API has slightly changed, so this is just a bit more than a ./mach vendor rust.
Attached patch 1.patch (obsolete) — Splinter Review
Functional changes. Second patch will come with the result of mach vendor rust,  both patches should be fused before landing.
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #9034413 - Flags: review?(sunfish)
Attached patch 2.patch (obsolete) — Splinter Review
can haz rubberstamp plz
Attachment #9034414 - Flags: review?(sunfish)
Attached patch 3.patch (obsolete) — Splinter Review
cargo +stable fmt (I'll merge this with the patch too)
Attachment #9034419 - Flags: review?(sunfish)
Comment on attachment 9034413 [details] [diff] [review]
1.patch

Review of attachment 9034413 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good!
Attachment #9034413 - Flags: review?(sunfish) → review+
Comment on attachment 9034414 [details] [diff] [review]
2.patch

Review of attachment 9034414 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #9034414 - Flags: review?(sunfish) → review+
Comment on attachment 9034419 [details] [diff] [review]
3.patch

Review of attachment 9034419 [details] [diff] [review]:
-----------------------------------------------------------------

Happily, it seems like the changes get smaller each rustfmt release, so it seems to be starting to settle in :-).
Attachment #9034419 - Flags: review?(sunfish) → review+
Attached patch folded.patchSplinter Review
Folded in patch, carrying forward r+ from Dan.
Attachment #9034413 - Attachment is obsolete: true
Attachment #9034414 - Attachment is obsolete: true
Attachment #9034419 - Attachment is obsolete: true
Attachment #9034448 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9a4aab87dc85
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.