currency-amount.js is a javascript module and shouldn't define "use strict";

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P5
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: standard8, Assigned: matthewacha, Mentored)

Tracking

(Blocks 1 bug, {coverity, good-first-bug})

unspecified
Firefox 66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
currency-amount.js is a javascript module and shouldn't define "use strict"

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#Strict_mode_for_modules

https://searchfox.org/mozilla-central/search?q=currency-amount.js&case=true&regexp=false&path=

We should drop that statement as it is redundant.

I'm happy to mentor this.
(Assignee)

Comment 1

3 months ago
Hey @standard8,
I would like to work on this bug, however, I would like you to know that this is my first time to contribute here and need some guidance on setup.
(Reporter)

Comment 2

3 months ago
Hi, to get set up, follow the steps here:

https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

Note that you probably don't need to do a build here, but creating one won't hurt. When you get to the './mach bootstrap' step, select the 'artifact' mode.

Once you've got the source, and created a patch, create a commit using this title: 'Bug 1517753 - currency-amount.js is a javascript module and shouldn't define "use strict" r?Standard8'

You can the submit it to phabricator for review:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Note: use the "moz-phab" submission method, rather than the arcanist one.

If you need more help, you can ask in #introduction on IRC (https://wiki.mozilla.org/IRC), or ask here.
Assignee: nobody → matthewacha
(Assignee)

Comment 3

3 months ago
Ok, thanks @standard8
(Assignee)

Comment 4

3 months ago
- Deleted 'use strict' from currency-amount.js
(Assignee)

Comment 5

3 months ago

@standard8 I have worked on it. Its awaiting your review

(Reporter)

Comment 6

3 months ago

(In reply to matthewacha from comment #5)

@standard8 I have worked on it. Its awaiting your review

Did you see my comment here: https://phabricator.services.mozilla.com/D15960#402927 ?

Comment 7

3 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff2df6d75dd4
currency-amount.js is a javascript module and shouldn't define "use strict" r=Standard8

Comment 8

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.