siteDataSettings.js should have "use strict" before any other statements

RESOLVED FIXED in Firefox 66

Status

()

P5
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: standard8, Assigned: danielleleb12, Mentored)

Tracking

(Blocks: 1 bug, {coverity, good-first-bug})

unspecified
Firefox 66
coverity, good-first-bug
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
Currently siteDataSettings.js has `"use strict";` defined after the imports, however the strict statement should be the first one in the file - just after the license header.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#Strict_mode_for_scripts

https://searchfox.org/mozilla-central/rev/ecf61f8f3904549f5d65a8a511dbd7ea4fd1a51d/browser/components/preferences/siteDataSettings.js#14

I'm happy to mentor someone on this, easy patch to get used to the process.
Blocks: 1230156
Keywords: coverity

Updated

3 months ago
Priority: -- → P5
(Assignee)

Comment 1

2 months ago

If this issue is still available, I would like to do it as my first bug.

(Reporter)

Comment 2

2 months ago

Hi, as far as I know no-one else is working on it, so please take it - I've assigned it to you.

If you need any help, please ask here or in #introduction on IRC (https://wiki.mozilla.org/IRC).

Assignee: nobody → danielleleb12
Status: NEW → ASSIGNED

Comment 4

2 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3793bfd5c19d
Moves 'use strict' statement to top of file. r=Standard8

Comment 5

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.