Closed Bug 1517756 Opened 2 years ago Closed 2 years ago

siteDataSettings.js should have "use strict" before any other statements

Categories

(Firefox :: Preferences, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: standard8, Assigned: danielleleb12, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Currently siteDataSettings.js has `"use strict";` defined after the imports, however the strict statement should be the first one in the file - just after the license header.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#Strict_mode_for_scripts

https://searchfox.org/mozilla-central/rev/ecf61f8f3904549f5d65a8a511dbd7ea4fd1a51d/browser/components/preferences/siteDataSettings.js#14

I'm happy to mentor someone on this, easy patch to get used to the process.
Priority: -- → P5

If this issue is still available, I would like to do it as my first bug.

Hi, as far as I know no-one else is working on it, so please take it - I've assigned it to you.

If you need any help, please ask here or in #introduction on IRC (https://wiki.mozilla.org/IRC).

Assignee: nobody → danielleleb12
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3793bfd5c19d
Moves 'use strict' statement to top of file. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.