1517775 - System update uninstall all the system addon and reinstalls them

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Trishul]

Attachment: XPIInstall-jsm-3256.png

What: On every update for system addons, all the system addons are uninstalled and them reinstalled, there should be no uninstall of the addons which are received in the update.

Observation:
In XPIInstall.jsm, in `installAddonSet` method, it checks `aAddons.includes(addonID)` and if not present in the set received from updates, it should uninstall the respective addon. But this condition is always false(as its trying to compare object to string) and hence all system addons are uninstalled.

aAddons => an Array of (addon)Objects
addonID => a String
aAddons.includes(addonID) => always false

https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIInstall.jsm#3256

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hi there - There's no need to needinfo anyone to try to get attention for your bug. All new bugs are triaged by the addons team following their regular schedule: https://wiki.mozilla.org/Add-ons/Contribute/Triage

Comment 2

[Trishul]

1. Its a Firefox Bug | Not a feature request and for sure its not 'my bug'
2. Bug reporting is generally about bringing to attention | Not trying to get attention
3. Volunteering is considered a friendly business | Thanks for your 'unfriendly' comment
4. Consider removing 'Needinfo please' from your name? | If you don't want one.

Comment 3

[David Durst [:ddurst]]

(In reply to Trishul from comment #2)
> 1. Its a Firefox Bug | Not a feature request and for sure its not 'my bug'
> 2. Bug reporting is generally about bringing to attention | Not trying to get attention
> 3. Volunteering is considered a friendly business | Thanks for your 'unfriendly' comment
> 4. Consider removing 'Needinfo please' from your name? | If you don't want one.

Trishul, I think you're reading a tone into Jared's comment that isn't there.

He's not being unfriendly, he's just pointing out protocol and removing himself from the thread. (By "attention" he doesn't mean that you're saying "look at me!" -- but rather "please don't miss this bug!")

The Add-ons team triages all Add-ons bugs weekly (based on the Product and Component of the bug), without any needinfo's being added.

Jared's "needinfo please" is standard practice, as is asking for needinfo on a particular issue or once a bug fix is in progress -- but in this case, he's not a good candidate for a needinfo anyway as he's not on the Add-ons team.

* * *

That said, this is a place where our work overlaps with other teams, so a regression window for this would probably help diagnose it faster.

Comment 4

[Trishul]

Hi David, I might have misunderstood this.
Thanks for clarifying and moving this faster.

Comment 5

[Robert Helmer [:rhelmer]]

This does look like a real bug to me based on comment #0, thanks Trishul for digging into that!

I recall there being a test for this so I suspect it's broken.

Comment 6

[Andrew Swan [:aswan]]

This looks like a long-standing bug, and I don't see any existing test that covers this.
In any case, it only occurs when there is a change to the set of active system addons.

Comment 7

[Trishul]

Attachment: Bug 1517775 - Prevents uninstall of all system addons at time of update r=aswan

Prevents uninstall of all system addons at time of update

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4706c0aade4
Prevents uninstall of all system addons at time of update r=aswan

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b4706c0aade4