[wpt-sync] Sync PR 14724 - [Resource-Timing] Fix non-zero secureConnectionStart in cleartext http

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
7 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 14724 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14724
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:
>  [Resource-Timing] Fix non-zero secureConnectionStart in cleartext http
>  
>  It seems we introduced[1] an issue inte secureConnectionStart values
>  where we wrongfully expose the fetchStart value there in cases where the
>  connection is not secure.
>  I'm fixing the spec[2], as it was a literal implementation of the "on
>  getting" processing there. This CL fixes our implementation.
>  
>  [1] https://chromium-review.googlesource.com/c/chromium/src/+/1363906
>  [2] https://github.com/w3c/resource-timing/pull/194
>  
>  Change-Id: Ib5e74ff70eddb0a96506e8955c5df2b01cc3d73a
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1396129
>  WPT-Export-Revision: 46582159436b3ecf3eef01ce0cb42f7ed331cf17
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 2 tests and 8 subtests
OK     : 1
PASS   : 3
FAIL   : 5

New tests that have failures or other problems:
/resource-timing/resource_connection_reuse.https.html
    connectEnd and fetchStart should be the same: FAIL
    connectStart and fetchStart should be the same: FAIL
    domainLookupEnd and fetchStart should be the same: FAIL
    domainLookupStart and fetchStart should be the same: FAIL
    secureConnectStart and fetchStart should be the same: FAIL

Tests that are disabled for instability:
/resource-timing/resource_connection_reuse.html
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/049104c8c153
[wpt PR 14724] - [Resource-Timing] Fix non-zero secureConnectionStart in cleartext http, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/12b57b944376
[wpt PR 14724] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/305d1c08372b
[wpt PR 14724] - [Resource-Timing] Fix non-zero secureConnectionStart in cleartext http, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/14c727acec10
[wpt PR 14724] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.