Closed Bug 1517942 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14730 - Fixing web platform tests for PeerConnection.setRemoteDescription().

Categories

(Core :: WebRTC, enhancement, P4)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14730 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14730
Details from upstream follow.

Amit Hilbuch <amithi@chromium.org> wrote:
>  Fixing web platform tests for PeerConnection.setRemoteDescription().
>  
>  Tests for PeerConnection.setRemoteDescription() did not call
>  setLocalDescription() on the caller object after creating the offer.
>  When the local description is not set, the PeerConnection can generate new MIDs
>  for the existing media sections. This caused tests to fail because the offer
>  was set on the callee causing the MIDs (and therefore media sections) not to
>  match.
>  
>  Bug: None.
>  Change-Id: I67e98e5abf76a97ab57fc0427672313b44f9c258
>  Reviewed-on: https://chromium-review.googlesource.com/1396854
>  WPT-Export-Revision: ebe979fa24af95487b6d2750e850afb3842d4d6b
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests and 5 subtests
OK     : 1
PASS   : 4
FAIL   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e67c3142513
[wpt PR 14730] - Fixing web platform tests for PeerConnection.setRemoteDescription()., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02828ac2fb87
[wpt PR 14730] - Fixing web platform tests for PeerConnection.setRemoteDescription()., a=testonly

https://hg.mozilla.org/mozilla-central/rev/02828ac2fb87

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.