1517952 - Make all Cu.imports explicit in WE code

Status: RESOLVED DUPLICATE of bug 1514594

(WebExtensions :: General, defect, P3)

Description

[Tomislav Jovanovic :zombie]

As a side-effect of bug 1514594, I now have an accurate list of exports for each module, so an automatic mass-rewrite seems easily doable.

The plan is to do this across m-c, but this is the first step to test how it works out, in code I'm familiar with.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1517952 - Modify defineLazyModuleGetter and use it in WE api scripts r=rpl!

Web Extension API scripts share the global, so we can't use an explicit
imoport in one, and a lazy import in another script:

var {Foo} = Cu.import("Foo.jsm", null);         // ext-a.js
Cu.defineModuleGetter(this, "Foo", "Foo.jsm");  // ext-b.js

The above throws because `var` defines a non-configurable property on the
global.  For similar reasons, two `const` imports in two api scripts don't
work either.

This solution modifies `XPCOMUtils.defineLazyModuleGetter` to bail early
if the imported property already exists on the global, and switch all WE
api scripts to use that instead the `ChromeUtils.defineModuleGetter`.

(This is all temporary until we can move to ES6 modules, but also required
before we can do that, Bug 1308512)

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: Bug 1517952 - Fixup some module exports to be on the global r=rpl!

To be able to explicitly import them using:

var {Foo} = Cu.import("Foo.jsm", null);

Depends on D16083

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1517952 - Make all Cu.imports explicit in WE code r=rpl!

Depends on D16084