Closed Bug 1518031 Opened 2 years ago Closed 2 years ago
Add to addressbar in the Page Actions menu gives a blank icon when you pin "Add Search Engine"
Bug 1518031 - Update "Add Search Engine" page action image when search engine icon becomes available.
47 bytes, text/x-phabricator-request
|Details | Review|
Tested on latest x86 Nightly build on Windows 10 If you try to pin "Add Search Engine" to the addressbar from the Page Actions menu, you get a blank icon. It functions but it's blank. Steps to reproduce 1. Visit ecosia.com or any other page with a search engine you haven't installed (Bugzilla works too) 2. Click the Page Actions menu 3. Right click on "Add Search Engine" and select "Add to Addressbar" Results: It gets added to the addressbar with no icon Expected: We get some kind of icon in the addressbar.
WFM on Mac (2019-01-06) - I get the favicon of the Ecosia page.
Component: Address Bar → Toolbars and Customization
We can just add `onLinkIconAvailable` to `TabsProgressListener` in browser.js and update the search badge.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8dbf2f4f7c53 Update "Add Search Engine" page action image when search engine icon becomes available. r=mossop
You need to log in before you can comment on or make changes to this bug.