1518073 - Prop types missing from some IFV components

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement, P1)

Description

[Ed Morley [:emorley]]

Some upstream fixes have been landed to eslint-plugin-react, which means it now correctly spots missing prop types in cases that it didn't before.

This means it's now warning about missing prop types in a few of the components under `ui/intermittent-failures/`, such as:

error: 'graphData' is missing in props validation (react/prop-types) at ui/intermittent-failures/BugDetailsView.jsx:17:5:
  15 | const BugDetailsView = props => {
  16 |   const {
> 17 |     graphData,
     |     ^
  18 |     tableData,
  19 |     initialParamsSet,
  20 |     startday,

See:
https://travis-ci.org/mozilla/treeherder/jobs/475839006#L215
https://github.com/mozilla/treeherder/pull/4406

Sarah, I don't suppose you could push the prop type changes to the branch for that PR, so we can unblock merging it and pick up the other fixes? :-)

Comment 1

[Sarah Clements [:sclements]]

Attachment: Commit 90bdf1f

Comment 2

[Sarah Clements [:sclements]]

Comment on attachment 9034884 [details] [diff] [review]
Commit 90bdf1f

https://github.com/mozilla/treeherder/pull/4406

Comment 3

[Sarah Clements [:sclements]]

Attachment: GitHub Pull Request

Commit #90bd1f1