Remove use of document.l10n.formatValues in aboutDialog.js

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jaws, Assigned: chengy12, Mentored)

Tracking

(Blocks 1 bug)

Trunk
Firefox 66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

aboutDialog.js uses formatValues to append the architecture of the build to the version number. We should be using Fluent arguments for this.

See errant code at https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/browser/base/content/aboutDialog.js#57

aboutDialog.ftl is located at https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/aboutDialog.ftl

You will need to use document.l10n.setAttributes to set the ID and attributes for the element. The definition of setAttributes is at https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/intl/l10n/DOMLocalization.jsm#474

Priority: -- → P3
Assignee: nobody → chengy12
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 months ago
Depends on D16716
Attachment #9037086 - Attachment description: Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
Attachment #9037086 - Attachment is obsolete: true
Attachment #9036973 - Attachment is obsolete: true
Attachment #9037104 - Attachment description: Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
Attachment #9037104 - Attachment description: Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws
Attachment #9037104 - Attachment description: Bug 1518220 - Replace the usage of formatValues with Flunt arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws
Attachment #9037104 - Attachment description: Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs!,jaws!
Attachment #9037104 - Attachment description: Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs!,jaws! → Bug 1518220 - Replace the usage of formatValues with Fluent arguments, r?Gijs,jaws

Comment 4

3 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a3cb2c2431d
Replace the usage of formatValues with Fluent arguments, r=jaws,flod

Comment 5

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.