talos help text for deprecated "sps" commands should point to hyphenated --gecko-profile options, not camelcase --geckoProfile options

RESOLVED FIXED in Firefox 66

Status

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Version 3
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago

./mach talos-test --help has a confusing papercut right now.

It says this:

--spsProfile (Deprecated - Use --geckoProfile instead.) Profile the
run and output the results in $MOZ_UPLOAD_DIR.

...but then it doesn't have anything about --geckoProfile. Instead, it offers this slightly different spelling:

--gecko-profile Profile the run and output the results in [...]

As it turns out, both --gecko-profile and --geckoProfile will work (for now, see bug 1518313), but we only offer help text for the hyphenated version. So, we should update the deprecation message to point to the hyphenated version too.

(We can make this help-text-tweak independently from & prior to bug 1518313 -- and we probably should do so.)

Assignee

Updated

5 months ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Assignee

Comment 2

5 months ago

Historical note: it looks like bug 1502922 added the hyphenated commands (and suppressed the help text for the camelcase commands).

Depends on: 1502922

Comment 3

5 months ago
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/292cf0b8d5c8
Adjust talos help text to point to documented --gecko-profile commands (rather than undocumented --geckoProfile aliases). r=rwood

Comment 4

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.