1518339 - user-select: none prevents selection in editable stuff in Gecko, but not in WebKit / Blink.

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Testcase

See test-case. We prevent selection even for editable stuff, but WebKit doesn't.

This is the underlying issue of bug 1511391.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Mats, wdyt?

Would you be fine gating selection on both -moz-user-select and -moz-user-modify, so that -moz-user-modify: read-write always implies selectability?

Maybe other ideas? Or maybe we should file a Blink bug instead?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Meant to ni? for comment 1.

Comment 3

[Mats Palmgren (inactive)]

It seems cleaner to keep the properties orthogonal and true to their meaning.

Could we fix it by adding something like "[contenteditable=true] { -moz-user-select: text }" in the UA sheet instead?
Alternatively, hack "​UsedUserSelect" to stop the "inheritance" at an "independent selection" boundary?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Out of curiosity, I took a look at what Blink does and it is:

https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/node.cc?l=1444&rcl=74f7e3bae00284cfb20de1f89275f2cb426c5d41

Oh well.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1518339 - Make user-select: auto behave like user-select: text for editing roots.

This is the closest to the spec behavior, I think, and less likely to
cause interop issues, but if you prefer me to stop the 'inheritance' chain at
contenteditable elements or what not I can also do that.

Comment 6

[Mats Palmgren (inactive)]

This looks fine, but I'd prefer to add the IsEditingHost block after
the "style != StyleUserSelect::Auto" block, so that it's possible to
override it by explicitly setting a non-auto value on the editable element.
That's not what the spec currently says, but it's what you suggest in
https://github.com/w3c/csswg-drafts/issues/3344, right?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

(In reply to Mats Palmgren (:mats) from comment #6)

This looks fine, but I'd prefer to add the IsEditingHost block after
the "style != StyleUserSelect::Auto" block, so that it's possible to
override it by explicitly setting a non-auto value on the editable element.
That's not what the spec currently says, but it's what you suggest in
https://github.com/w3c/csswg-drafts/issues/3344, right?

Yeah, I agree that's better over-all. Done :)

Comment 8

[Mats Palmgren (inactive)]

Thanks. Yeah, it's easy to change if #3344 comes to a different consensus,
but for now this is good since it also allows us to see if it's web-compatible.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bacb9f000cc
Make user-select: auto behave like user-select: text for editing roots. r=mats

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0bacb9f000cc