1518459 - unable to run test-verify backfill due to invalid syntax

Status: RESOLVED DUPLICATE of bug 1515653

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

https://taskcluster-artifacts.net/eWZ-1cekSnqlDbN4ePCwYA/0/public/logs/live_backing.log

[task 2019-01-08T13:09:07.511Z] 13:09:07 ERROR - Exception during post-action for download-and-extract: Traceback (most recent call last):
[task 2019-01-08T13:09:07.512Z] 13:09:07 ERROR - File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2040, in run_action
[task 2019-01-08T13:09:07.513Z] 13:09:07 ERROR - method(action, success=success and self.return_code == 0)
[task 2019-01-08T13:09:07.514Z] 13:09:07 ERROR - File "/builds/worker/workspace/mozharness/mozharness/mozilla/testing/verify_tools.py", line 49, in find_tests_for_verification
[task 2019-01-08T13:09:07.514Z] 13:09:07 ERROR - self.find_modified_tests()
[task 2019-01-08T13:09:07.515Z] 13:09:07 ERROR - File "/builds/worker/workspace/mozharness/mozharness/mozilla/testing/per_test_base.py", line 244, in find_modified_tests
[task 2019-01-08T13:09:07.516Z] 13:09:07 ERROR - changed_files |= itertools.chain.from_iterable(suite_to_paths.values())
[task 2019-01-08T13:09:07.517Z] 13:09:07 ERROR - TypeError: unsupported operand type(s) for |=: 'set' and 'itertools.chain'

this was added as part of bug 1489100.

here is a link to the code:

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

and the link exists here:
https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/per_test_base.py#244

the change in question is related to:
original:
changed_files |= set(os.environ['MOZHARNESS_TEST_PATHS'].split(':'))

new:
suite_to_paths = json.loads(os.environ['MOZHARNESS_TEST_PATHS'])
changed_files |= itertools.chain.from_iterable(suite_to_paths.values())

I am not sure why we have suite_to_paths now, I assume this itertools.chain.from_iterable will do some magic to this? Maybe a fix is to just add a set() like we used to have? Maybe it needs to be changed_files.update(...)

we also had similar changes (from the same patch) in perfile.py:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/util/perfile.py#54

:marco, can you get this fixed?