Closed Bug 1518496 Opened 6 years ago Closed 6 years ago

Restore previous session setting does not work from red close button in macOS

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
64 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: 13hurdw, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

macOS 10.14.2

about:preferences
check "Restore previous session"

Start new multiple tab session, close it

Restart FF

Actual results:

Confirm close multiple tabs dialog on close. On restart, open tabs are not restored.

Expected results:

Open tabs are restored on restart

Component: Untriaged → Session Restore
Severity: normal → major
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86_64

Dear 13hw, we really need more information to be able to reproduce this issue, because with the steps you give in comment 0, I can't reproduce it.

Please re-open this bug when you are able to provide the following details:

  • Amount of windows and tabs you had open,
  • Which sites you had loaded at the time you quit Firefox,
  • The method you used to quit Firefox,
  • and the contents of your about:support

Thanks!

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME

Had one window with many tabs (~15)

Did not restore when quitting via the red x button.
Restore worked with Firefox - Quit Firefox

The system setting "Reopen windows when logging back in" is unchecked. I think this may have something to do with it.

Application Basics
------------------

Name: Firefox
Version: 64.0.2
Build ID: 20190108160530
Update Channel: release
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0
OS: Darwin 18.2.0
Multiprocess Windows: 3/3 (Enabled by default)
Web Content Processes: 5/4
Enterprise Policies: Inactive
Google Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Crash Reports for the Last 3 Days
---------------------------------

All Crash Reports     Firefox Features
--------------------------------------

Name: Firefox Monitor
Version: 2.8
ID: fxmonitor@mozilla.org

Name: Firefox Screenshots
Version: 35.0.0
ID: screenshots@mozilla.org

Name: Form Autofill
Version: 1.0
ID: formautofill@mozilla.org

Name: Web Compat
Version: 3.0.0
ID: webcompat@mozilla.org

Name: WebCompat Reporter
Version: 1.1.0
ID: webcompat-reporter@mozilla.org

Extensions
----------


Security Software
----------------- Type:

Type:

Type:

Graphics
--------

Features
Compositing: OpenGL
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
WebGL 1 Driver WSI Info: CGL
WebGL 1 Driver Renderer: ATI Technologies Inc. -- AMD Radeon Pro 560X OpenGL Engine
WebGL 1 Driver Version: 4.1 ATI-2.4.9
WebGL 1 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context
WebGL 2 Driver WSI Info: CGL
WebGL 2 Driver Renderer: ATI Technologies Inc. -- AMD Radeon Pro 560X OpenGL Engine
WebGL 2 Driver Version: 4.1 ATI-2.4.9
WebGL 2 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context
Uses Tiling: true
Uses Tiling (Content): true
Off Main Thread Painting Enabled: true
Off Main Thread Painting Worker Count: 4
GPU #1
Active: Yes
Vendor ID: 0x8086
Device ID: 0x3e9b

Diagnostics
AzureCanvasAccelerated: 0
AzureCanvasBackend: skia
AzureContentBackend: skia
AzureFallbackCanvasBackend: none
TileHeight: 1024
TileWidth: 1024
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
WEBRENDER_QUALIFIED:
blocked by env: No qualified hardware




Media
-----

Audio Backend: audiounit
Max Channels: 2
Preferred Sample Rate: 48000
Output Devices
Name: Group
MacBook Pro Speakers: BuiltInSpeakerDevice
External Headphones: BuiltInHeadphoneOutputDevice
Input Devices
Name: Group
MacBook Pro Microphone: BuiltInMicrophoneDevice

Important Modified Preferences
------------------------------


Important Locked Preferences
----------------------------

Places Database
---------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 1

Library Versions
----------------

NSPR
Expected minimum version: 4.20
Version in use: 4.20

NSS
Expected minimum version: 3.40.1
Version in use: 3.40.1

NSSSMIME
Expected minimum version: 3.40.1
Version in use: 3.40.1

NSSSSL
Expected minimum version: 3.40.1
Version in use: 3.40.1

NSSUTIL
Expected minimum version: 3.40.1
Version in use: 3.40.1

Sandbox
-------

Content Process Sandbox Level: 3
Effective Content Process Sandbox Level: 3
Summary: Restore previous session setting does not work in macOS → Restore previous session setting does not work from red close button in macOS

Yeah, when you close the window using the close button, it won't automatically restore back when you re-open Firefox the next time; you'll need to quit Firefox with the window open instead.
This is because closing a window using the button like that, signals your intent that you don't want to have it back open when you restart Firefox.

(In reply to Mike de Boer [:mikedeboer] from comment #3)

Yeah, when you close the window using the close button, it won't automatically restore back when you re-open Firefox the next time; you'll need to quit Firefox with the window open instead.
This is because closing a window using the button like that, signals your intent that you don't want to have it back open when you restart Firefox.

When I use the close button, it does seem to quit the app though (the dot disappears on the dock), so I would expect it to restore.

This is because closing a window using the button like that, signals your intent that you don't want to have it back open when you restart Firefox.

I see, I guess I don't have the same intent/expectation with using the close button.
If I quit using the close window button on other platforms (Windows and Linux), it still restores the session when FF is reopened.

My expectation is if I set the restore previous session preference, it should always restore my previous session no matter how I close the app.
This is how Chrome behaves and FF seems to behave on other platforms.

This is exactly how MacOS is different from other platforms; using the close button on a window does not quit the app.
I'd be surprised if Chrome did things differently here, but okay.
You're right that Firefox behaves differently on other platforms, exactly because we should always conform to the UX conventions there.

Ok, I see, thanks.

You need to log in before you can comment on or make changes to this bug.