Closed Bug 1518512 Opened 10 months ago Closed 9 months ago

Track Changes - Changes panel misses context menu

Categories

(DevTools :: Inspector, defect, P3)

65 Branch
defect

Tracking

(firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: mbalfanz, Assigned: rcaliman)

References

(Blocks 1 open bug)

Details

(Whiteboard: [dt-q])

Attachments

(2 files)

Until exporting is implemented, the changes panel should offer the normal context menu provided by the operating system which options to copy/paste/select all...

STR:

  • track some changes
  • highlight the collected changes
  • click the right mouse button on the selection

ER:

  • the context menu should open, allowing to copy the text

AR:

  • context menu doesn't open
Whiteboard: [dt-q]
Component: General → Inspector
Priority: -- → P3
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Summary: Changes panel misses context menu → Track Changes - Changes panel misses context menu

Adds context menu with options to select all and copy text content from
the Changes panel.

Depends on D17255
Replaces CSS pseudo-elements for added/removed line markers with text
elements that can be copied with the rest of the content.

Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c03e2282b4f
(Part 1) Add basic context menu to Changes panel. r=gl
https://hg.mozilla.org/integration/autoland/rev/c8f0d19844f6
(Part 2) Ensure all text in Changes panel can be copied. r=gl

Backed out for devtools/client/inspector/changes/test/browser_changes_rule_selector.js failures.

backout: https://hg.mozilla.org/integration/autoland/rev/a7918210d2f16d02f02f7a322375a358fe710e3a

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c8f0d19844f67cd9a2189f612e4f1a865d697b04&searchStr=devtools&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224014389&repo=autoland&lineNumber=4175

[task 2019-01-25T13:07:53.009Z] 13:07:53 INFO - TEST-PASS | devtools/client/inspector/changes/test/browser_changes_rule_selector.js | First rule has only one declaration -
[task 2019-01-25T13:07:53.013Z] 13:07:53 INFO - Buffered messages finished
[task 2019-01-25T13:07:53.015Z] 13:07:53 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/changes/test/browser_changes_rule_selector.js | First rule has correct declaration - Got - color: red;, expected color:red;
[task 2019-01-25T13:07:53.017Z] 13:07:53 INFO - Stack trace:
[task 2019-01-25T13:07:53.019Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:test_is:1318
[task 2019-01-25T13:07:53.020Z] 13:07:53 INFO - chrome://mochitests/content/browser/devtools/client/inspector/changes/test/browser_changes_rule_selector.js:null:57
[task 2019-01-25T13:07:53.022Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
[task 2019-01-25T13:07:53.024Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
[task 2019-01-25T13:07:53.031Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
[task 2019-01-25T13:07:53.033Z] 13:07:53 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-01-25T13:07:53.035Z] 13:07:53 INFO - TEST-PASS | devtools/client/inspector/changes/test/browser_changes_rule_selector.js | First rule has declaration tracked as removed -
[task 2019-01-25T13:07:53.036Z] 13:07:53 INFO - TEST-PASS | devtools/client/inspector/changes/test/browser_changes_rule_selector.js | Second rule has only one declaration -
[task 2019-01-25T13:07:53.038Z] 13:07:53 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-01-25T13:07:53.039Z] 13:07:53 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/changes/test/browser_changes_rule_selector.js | Second rule has correct declaration - Got + color: red;, expected color:red;
[task 2019-01-25T13:07:53.041Z] 13:07:53 INFO - Stack trace:
[task 2019-01-25T13:07:53.043Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:test_is:1318
[task 2019-01-25T13:07:53.044Z] 13:07:53 INFO - chrome://mochitests/content/browser/devtools/client/inspector/changes/test/browser_changes_rule_selector.js:null:63
[task 2019-01-25T13:07:53.045Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
[task 2019-01-25T13:07:53.047Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
[task 2019-01-25T13:07:53.049Z] 13:07:53 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
[task 2019-01-25T13:07:53.050Z] 13:07:53 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-01-25T13:07:53.051Z] 13:07:53 INFO - TEST-PASS | devtools/client/inspector/changes/test/browser_changes_rule_selector.js | Second rule has declaration tracked as added -

Flags: needinfo?(rcaliman)
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21af538eb319
(Part 1) Add basic context menu to Changes panel. r=gl
https://hg.mozilla.org/integration/autoland/rev/99655666ac5a
(Part 2) Ensure all text in Changes panel can be copied. r=gl

Fixed failing test and queued again for landing

Flags: needinfo?(rcaliman)
Blocks: 1522843
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.