1518551 - Remove the MOZ_TOOLKIT_SEARCH define

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mike de Boer [:mikedeboer]]

During the review phase of bug 1492475, we noticed that the 'MOZ_TOOLKIT_SEARCH' build-time define doesn't really serve a purpose anymore.
Let's remove it.

Comment 1

[Manish [:manishkk]]

need to remove only 'MOZ_TOOLKIT_SEARCH' from here: https://searchfox.org/mozilla-central/search?q=MOZ_TOOLKIT_SEARCH&case=false&regexp=false&path=

Comment 3

[Mike de Boer [:mikedeboer]]

Yes, I think that's correct, Manish. Thanks for taking a look!

Comment 4

[Manish [:manishkk]]

Attachment: Bug 1518551- Remove the MOZ_TOOLKIT_SEARCH define

Comment 5

[Mark Banner (:standard8)]

Hi Manish, did you see Mike's comments on the patch?

Are you still working on this?

Comment 6

[Manish [:manishkk]]

Sorry not able to give time because of my Ph.D.
I am un-assigning this bug.

Comment 7

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9f3c6cbba3878044fbefe3581a3ffb43d3ae6bd

Comment 8

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1518551 - Remove the 'MOZ_TOOLKIT_SEARCH' build config constant, because it's unused; we always enable the search service. r?florian!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da2bd2908b71
Remove the 'MOZ_TOOLKIT_SEARCH' build config constant, because it's unused; we always enable the search service. r=florian

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/da2bd2908b71