Closed
Bug 1518564
Opened 6 years ago
Closed 6 years ago
Stop using bluebird
Categories
(Taskcluster :: Services, enhancement)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: biboswan98)
References
Details
I just noticed /app/node_modules/bluebird in a traceback. In modern node, the built-in Promise is just fine, so we should be using that instead. I think there's one feature of bluebird that we use (Promise.race, iirc), so let's just work around that.
|
||
Comment 1•6 years ago
|
||
I think we use it for Promise.map the most but that is just a bit of syntactic sugar we can definitely live without.
|
|
||
Updated•6 years ago
|
Assignee: nobody → biboswan98
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•6 years ago
|
||
|
Reporter | |
Comment 3•6 years ago
|
||
Looks like https://github.com/taskcluster/taskcluster/pull/80 is landed, and I think there was one followup (for Promise.prototype.timeout). Is this bug done?
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 4•6 years ago
|
||
yes i think
|
||
Updated•6 years ago
|
Component: Platform and Services → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•