1518609 - Add Telemetry to determine when maxRetransmitTime in DataChannel init can be deprecated

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The maxRetransmitTime parameter to DataChannel init has been renamed maxPacketLifeTime. We already have a warning that the old name will be removed, we need to determine if that warning, and a future stronger warning are effective.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1518609 - Add telemetry to legacy maxRetransmitTime DataChannel param

Adds telemetry to the DataChannel init param maxRetransmitTime.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: telemetry_review_bug_1518609.txt

Telemetry review info

Comment 3

[Nils Ohlmeier [:drno]]

Nico I think you need to set the review flag on your telemetry review info file to one of the data stewards to get them to look at it and approve it.

Comment 4

[Chris H-C :chutten]

Comment on attachment 9035198 [details]
telemetry_review_bug_1518609.txt

Preliminary notes:

The data review request is requesting all channel collection, but the scalar definitions say `release_channel_collection: opt-in` which is collection on pre-release channels only. I will conduct the review on the basis that you do want the data collected on all channels and will fix the definitions to match.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file ([Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml)) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, this collection expires in Firefox 70.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :ng is responsible for renewing/removing this collection before it expires in Firefox 70.

---
Result: datareview+

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I verified that the telemetry scalars are being incremented as expected with https://jsfiddle.net/j2n05w97/ .

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Patches look ready to go here. Anything missing?

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Reminder to self, to land on Monday 3/18.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/841324f86e75
Add telemetry to legacy maxRetransmitTime DataChannel param r=jib,janerik

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/841324f86e75