1518663 - Extensions from policies.json only install on first run

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[William Osler]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

I've been trying to create an Enterprise Policy via policies.json that will install extensions from AMO, however, it only works the first time the browser is launched from a fresh profile.

Repro Steps:

1. Place this "policies.json" in the distributions/ directory of the Firefox install path:

{
"policies": {
"Extensions": {
"Install": [
"https://addons.mozilla.org/firefox/downloads/latest/darkreader",
"https://addons.mozilla.org/firefox/downloads/latest/vimium-ff",
"https://addons.mozilla.org/firefox/downloads/latest/ublock-origin"
],
"Uninstall": [],
"Locked": []
}
}
}

2. Run Firefox and view about:policies. The URLs show up under the Active tab. However, none of the extensions are ever installed, and in the Error tab it shows the following errors:

Policy Errors
Download failed - https://addons.mozilla.org/firefox/downloads/latest/ublock-origin
Download failed - https://addons.mozilla.org/firefox/downloads/latest/vimium-ff

3. Create a new Firefox profile "firefox --new-instance -P"

4. Observe that the extensions do actually install

5. Add an extension to "policies.json" (this is in order to trigger Firefox to reload the policy)

6. Restart Firefox with the new profile, go to about:policies, and notice that the same list of errors has appeared for every extension listed

Actual results:

Extensions will only be installed on the first run of Firefox on a fresh user profile. Otherwise there are errors in downloading the extensions.

Expected results:

Any change to policies.json should cause the new extensions to be installed successfully, without errors.

Comment 1

[Mike Kaply [:mkaply]]

Any change to policies.json should cause the new extensions to be installed successfully, without errors.

Any change to the list of extensions will cause them to be reinstalled, but not to policies.json in general.

Comment 2

[Mike Kaply [:mkaply]]

I get what your asking here.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1518663 - If policy extension download fails, try again.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29b08c635a7c
If policy extension download fails, try again. r=Felipe

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 29b08c635a7c (bug 1518663) for Browser-Chrome failures in browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237778007&repo=autoland&lineNumber=10426

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=29b08c635a7c7863ba4395ca9b7f74bdafc03aa2

Backout:
https://hg.mozilla.org/integration/autoland/rev/56528eeda044c5bc1fc15a89f89fdbb3ab0e05e4

Comment 6

[Mike Kaply [:mkaply]]

I'm at a loss. This passes locally and I clearly have a try catch around the await.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d76eea893d56
If policy extension download fails, try again. r=Felipe

Comment 8

[Andreea Pavel [:apavel]]

Backed out for failing bc at browser_policy_extensions.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=237935090&revision=0b7c0766362829e5e7f19831f5ae58f128eb8625

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237935090&repo=autoland&lineNumber=12007

Backout: https://hg.mozilla.org/integration/autoland/rev/d61ab098b5f0e5341a3031fdd565973816949b1b

Comment 9

[Mike Kaply [:mkaply]]

Argh. This went through chaos mode with no issues. I'll look more.

Comment 10

[Mike Kaply [:mkaply]]

This new version passes on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80755da1bdacd7c51999dbecf82232f93b5f5b0a&selectedJob=237968070

Relanding.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c20b3ba913d9
If policy extension download fails, try again. r=Felipe

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c20b3ba913d9

Comment 13

[Mike Kaply [:mkaply]]

Comment on attachment 9055251 [details]
Bug 1518663 - If policy extension download fails, try again.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy related
• User impact if declined: If a policy to install an extension fails, that extension won't be installed again
• Fix Landed on Version: 68
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, has automated test.
• String or UUID changes made by this patch:

Comment 14

[David Olah]

managed to reproduce the issue on Ubuntu 16.04 LTS, Nightly 64.0a1 (2018-10-01). It is not reproducible on Nightly 68.0a1 (2019-04-29), so I'll mark it as verified.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9055251 [details]
Bug 1518663 - If policy extension download fails, try again.

Fix for policy issue, verified in nightly.
OK for uplift for esr 60.7.

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/496d09494d87