Closed Bug 1518722 Opened 5 years ago Closed 5 years ago

Pocket context menu and library panel items still appear when disabled

Categories

(Firefox :: Pocket, defect)

66 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- unaffected
firefox66 --- verified

People

(Reporter: ke5trel, Assigned: Gijs)

References

Details

(Keywords: nightly-community, regression, reproducible)

Attachments

(2 files)

Attached image pocket-menu-items.png

STR:

  1. Set extensions.pocket.enabled = false
  2. Restart browser.
  3. Right-click a link.

Two Pocket-related context menu items appear (Save Link to Pocket, Save Page to Pocket) where there should be none.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3e906dc0b1e81089d1c65e0c7e23db8d8923f704&tochange=1f205f83805d44c9aaabd0ce25a43cc0b426a5ae

Regressed by Bug 1498295.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

I have noticed this presence of Pocket items since before the OP. In my case I have disabled Pocket through the DisablePocket policy (which sets extensions.pocket.enabled to false and locks it, at least) and though at first I didn't notice the reappearance of context menu items, it also shows the "View Pocket List" library item; previously it also showed the Pocket item in the Page Actions menu, but not today (odd, since this is how I noticed the issue in the first place).

Somehow related, but certainly not part of this bug as it happens since the introduction of the extensions.pocket.enabled preference (I think): in about:preferences#home, under Firefox Home Content/Highlights, the "Pages Saved to Pocket" checkbox is always there, even when extensions.pocket.enabled is set to false; shouldn't it vanish as every other Pocket UI element in this case?

(In reply to Mauro Sanabria from comment #3)

I have noticed this presence of Pocket items since before the OP. In my case I have disabled Pocket through the DisablePocket policy (which sets extensions.pocket.enabled to false and locks it, at least) and though at first I didn't notice the reappearance of context menu items, it also shows the "View Pocket List" library item;

I'm aware of this (already noted on phabricator) and investigating how best to fix.

previously it also showed the Pocket item in the Page Actions menu, but not today (odd, since this is how I noticed the issue in the first place).

If you find steps to reproduce this issue I'd be interested. It's also possible that I somehow fixed this but broke the other stuff with the changes in bug 1498295. Either way it would be good to know.

Somehow related, but certainly not part of this bug as it happens since the introduction of the extensions.pocket.enabled preference (I think): in about:preferences#home, under Firefox Home Content/Highlights, the "Pages Saved to Pocket" checkbox is always there, even when extensions.pocket.enabled is set to false; shouldn't it vanish as every other Pocket UI element in this case?

I guess. Probably worth filing a separate bug. I assume no pocket items show up in the new tab / homepage irrespective of whether the checkbox is ticked?

Summary: Pocket context menu items still appear when disabled → Pocket context menu and library panel items still appear when disabled

If this helps, I also wanted to note that the pocket icon does not appear in the page action area when starting Nightly with extensions.pocket.enabled=false, but the 2 Pocket menu items do, as reported. Unable to repro Mauro Sanabria's report of the icon appearing too, though.

Toggling the pref to true and back to false while FF is running removes the items from the menu, but they reappear on the next startup.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6479cf440470
default pocket context menus to hidden to fix behavior when setting pocket pref to false, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 66.0a1 (2019-01-16), so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Status: RESOLVED → VERIFIED
QA Contact: Virtual
See Also: → 1538464
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: