1518754 - [wpt-sync] Sync PR 14757 - RTCRtpReceiver.getSynchronizationSources() added.

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14757 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14757
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

RTCRtpReceiver.getSynchronizationSources() added.

This CL:

• Adds getSynchronizationSources() for both audio and video.
• Adds proper test coverage, including test coverage for unsupported
  members audioLevel and voiceActivityFlag. It turns out that our
  timestamps are not comparable to performance.now(), this should be
  fixed separately (this must already have been the case for
  getContributingSources() but not noticed until now).
• Removes the WPTs for getContributingSources() since these tests were
  not working (an SFU or the like or fakes/mocks are needed to test
  this, this is not something that is testable in WPTs).

Bug: 893158, 893160
Change-Id: Ic90344af7fa48c3cd0b94929cc9453deb9dc7f9f
Reviewed-on: https://chromium-review.googlesource.com/1401068
WPT-Export-Revision: d99630f15c38d2321de91e2c3789eb0167cf4117

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd3b729e68dbc80fed4c876fdfa1db626eec7e6a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a4820d2a94319dbb9cc8465e1e1199e5a8239d5

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9784406e203249e6a273338a8cd19c14bc2dd751

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 12 subtests
PASS   : 5
TIMEOUT: 2
NOTRUN : 6

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html: TIMEOUT

New tests that have failures or other problems:
/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html
    [audio-only] RTCRtpSynchronizationSource.audioLevel is a number [0, 1]: NOTRUN
    [audio-only] RTCRtpSynchronizationSource.voiceActivityFlag is a boolean: NOTRUN
    [video] RTCRtpSynchronizationSource.source is a number: NOTRUN
    [video] RTCRtpSynchronizationSource.timestamp is a number: NOTRUN
    [video] RTCRtpSynchronizationSource.timestamp is comparable to performance.timeOrigin + performance.now(): NOTRUN
    [video] getSynchronizationSources() does not contain SSRCs older than 10 seconds: NOTRUN
    [video] getSynchronizationSources() eventually returns a non-empty list: TIMEOUT

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a353865db5a
[wpt PR 14757] - RTCRtpReceiver.getSynchronizationSources() added., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e1fe68d4fa7
[wpt PR 14757] - Update wpt metadata, a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e1b2bb14876
[wpt PR 14757] - RTCRtpReceiver.getSynchronizationSources() added., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/40bb7ca11e2b
[wpt PR 14757] - Update wpt metadata, a=testonly

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/2e1b2bb14876
https://hg.mozilla.org/mozilla-central/rev/40bb7ca11e2b