Closed Bug 1518754 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14757 - RTCRtpReceiver.getSynchronizationSources() added.

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14757 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14757
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

RTCRtpReceiver.getSynchronizationSources() added.

This CL:

  • Adds getSynchronizationSources() for both audio and video.
  • Adds proper test coverage, including test coverage for unsupported
    members audioLevel and voiceActivityFlag. It turns out that our
    timestamps are not comparable to performance.now(), this should be
    fixed separately (this must already have been the case for
    getContributingSources() but not noticed until now).
  • Removes the WPTs for getContributingSources() since these tests were
    not working (an SFU or the like or fakes/mocks are needed to test
    this, this is not something that is testable in WPTs).

Bug: 893158, 893160
Change-Id: Ic90344af7fa48c3cd0b94929cc9453deb9dc7f9f
Reviewed-on: https://chromium-review.googlesource.com/1401068
WPT-Export-Revision: d99630f15c38d2321de91e2c3789eb0167cf4117

Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests and 12 subtests
PASS   : 5
TIMEOUT: 2
NOTRUN : 6

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html: TIMEOUT

New tests that have failures or other problems:
/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html
    [audio-only] RTCRtpSynchronizationSource.audioLevel is a number [0, 1]: NOTRUN
    [audio-only] RTCRtpSynchronizationSource.voiceActivityFlag is a boolean: NOTRUN
    [video] RTCRtpSynchronizationSource.source is a number: NOTRUN
    [video] RTCRtpSynchronizationSource.timestamp is a number: NOTRUN
    [video] RTCRtpSynchronizationSource.timestamp is comparable to performance.timeOrigin + performance.now(): NOTRUN
    [video] getSynchronizationSources() does not contain SSRCs older than 10 seconds: NOTRUN
    [video] getSynchronizationSources() eventually returns a non-empty list: TIMEOUT
See Also: → 1525394
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a353865db5a
[wpt PR 14757] - RTCRtpReceiver.getSynchronizationSources() added., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e1fe68d4fa7
[wpt PR 14757] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e1b2bb14876
[wpt PR 14757] - RTCRtpReceiver.getSynchronizationSources() added., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/40bb7ca11e2b
[wpt PR 14757] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.