Move stopListeners to the console actor

RESOLVED FIXED in Firefox 66

Status

enhancement
P1
normal
RESOLVED FIXED
6 months ago
Last month

People

(Reporter: yulia, Assigned: yulia)

Tracking

(Blocks 1 bug)

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(5 attachments)

Assignee

Description

6 months ago

We should not be doing RDP requests on destruction of fronts, so we should move stopListeners to the actor.

Assignee

Updated

6 months ago
Whiteboard: dt-fission
Assignee

Comment 1

6 months ago
Several of our tests relied on the timing of the shutdown of the webconsole. I updated one
test that fired off an extra rdp request so that it waiting until it resolved before shutting down.
For the rest, I started tracking the async behavior of initialization of the web-console-proxy, and
waiting for initialization to finish before destroying.
Assignee

Comment 2

6 months ago
This patch moves stopListeners to the actor, and removes the need for the callback in the
detach call on the client.
Assignee

Updated

6 months ago
Assignee: nobody → ystartsev
Attachment #9035602 - Attachment description: Bug 1518777 - ensure that netmonitor and console tests wait for initialization and open requests to finish before shutting down; r=ochameau, nchevobbe → Bug 1518777 - ensure that netmonitor and console tests wait for initialization and open requests tofinish before shutting down; r=ochameau, nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #9036873 - Attachment is obsolete: true
Attachment #9036873 - Attachment is obsolete: false

Comment 8

5 months ago
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bc02c7054fe
ensure that netmonitor and console tests wait for initialization and open requests tofinish before shutting down; r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/9c646afb94b2
move stopListeners from the client detach method to the actor destroy method; r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6a565ef5ffe7
add onReload event to navigated action; r=ochameau,jlast
https://hg.mozilla.org/integration/autoland/rev/e7cd613e6bfb
make stoplisteners use promise style callbacks; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b9058c98eccb
move webConsoleClient.detach to destroy; r=ochameau
You need to log in before you can comment on or make changes to this bug.