1518777 - Move stopListeners to the console actor

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Yulia Startsev [:yulia]]

We should not be doing RDP requests on destruction of fronts, so we should move stopListeners to the actor.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1518777 - ensure that netmonitor and console tests wait for initialization and open requests tofinish before shutting down; r=ochameau, nchevobbe

Several of our tests relied on the timing of the shutdown of the webconsole. I updated one
test that fired off an extra rdp request so that it waiting until it resolved before shutting down.
For the rest, I started tracking the async behavior of initialization of the web-console-proxy, and
waiting for initialization to finish before destroying.

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1518777 - move stopListeners from the client detach method to the actor destroy method; r=ochameau,nchevobbe

This patch moves stopListeners to the actor, and removes the need for the callback in the
detach call on the client.

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1518777 - add onReload event to navigated action; r=ochameau

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1518777 - make stoplisteners use promise style callbacks; r=ochameau

Comment 5

[Yulia Startsev [:yulia]]

Attachment: Bug 1518777 - move webConsoleClient.detach to destroy; r=ochameau

Comment 6

[Yulia Startsev [:yulia]]

Try Run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=171866aa4d5cbd31ffb4949ebf7713a36bde0460

Comment 7

[Yulia Startsev [:yulia]]

try run for rebase: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8c683165e6240e78caab3b4353493adb3a2cd5d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bc02c7054fe
ensure that netmonitor and console tests wait for initialization and open requests tofinish before shutting down; r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/9c646afb94b2
move stopListeners from the client detach method to the actor destroy method; r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6a565ef5ffe7
add onReload event to navigated action; r=ochameau,jlast
https://hg.mozilla.org/integration/autoland/rev/e7cd613e6bfb
make stoplisteners use promise style callbacks; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b9058c98eccb
move webConsoleClient.detach to destroy; r=ochameau

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2bc02c7054fe
https://hg.mozilla.org/mozilla-central/rev/9c646afb94b2
https://hg.mozilla.org/mozilla-central/rev/6a565ef5ffe7
https://hg.mozilla.org/mozilla-central/rev/e7cd613e6bfb
https://hg.mozilla.org/mozilla-central/rev/b9058c98eccb