1518793 - Add Microsoft Office to tp6

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P2)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This tracks adding Microsoft Office to tp6.

URL: https://office.live.com/start/Word.aspx?omkt=en-US&auth=1&nf=1

Use the credentials available in the shared 1Password vault.

Comment 1

[Florin Strugariu [:Bebe]]

Tried to record/replay/test this but failed.

We get a mitmproxy cookie error when replaying on chrome.

15:08:02    ERROR -  Script error: Traceback (most recent call last):
15:08:02     INFO -    File "/home/florinstrugariu/mozilla/mozilla-central/testing/raptor/raptor/playback/alternate-server-replay.py", line 172, in request
15:08:02     INFO -      response.refresh()
15:08:02     INFO -    File "mitmproxy/net/http/response.py", line 189, in refresh
15:08:02     INFO -    File "mitmproxy/net/http/cookies.py", line 296, in refresh_set_cookie_header
15:08:02     INFO -  IndexError: list index out of range

Tested this with mitmiproxy 4.04 and all works as expected.

the error we see was fixed by:
https://github.com/mitmproxy/mitmproxy/issues/2250

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Bug 1518793 Add Microsoft Office to tp6

Comment 3

[Robert Wood [:rwood]]

(In reply to Florin Strugariu [:Bebe] from comment #1)

Tested this with mitmiproxy 4.04 and all works as expected.


the error we see was fixed by:
https://github.com/mitmproxy/mitmproxy/issues/2250

I'm a bit confused, so this patch that you submitted will only work with mitmproxy 4.04 is that correct? In which case this cannot proceed.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I've marked bug 1457274 as a blocker. It's useful to share your patch :bebe but please don't request review if there's an unresolved blocker.

Comment 5

[Florin Strugariu [:Bebe]]

:rwood sorry for the review. I added the patch to be easier when we try to test this in the future

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Are we able to revisit this now we have support for mitmproxy 4.0.4?

Comment 7

[Florin Strugariu [:Bebe]]

Attachment: Bug 1518793 Add Microsoft Office to tp6

Comment 8

[Florin Strugariu [:Bebe]]

try build with screenshots:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=addb01038612e8442a10d7d841b24eb38a5b358d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/651ac84f173e
Add Microsoft Office to tp6 r=AlexandruIonescu

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/651ac84f173e