1518807 - [Content Blocking] Icons from preferences are invisible on high contrast mode

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[David Olah]

Attachment: CB_Standard.png

[Enviroments:]
Windows 10, Windows 7
66.0a1 (2019-01-09)

[Steps:]

1. Set a high contrast theme (example: black).
2. Open Firefox.
3. Open hamburger menu / select content blocking.

[Actual Result:]
The icons are the same color as the background and cannot be seen.

[Expected Result:]
The icons convert color to white as the rest of the icons from Mozilla options pages.

[Note]
In the Attachments you can see a comparison between standard and High contrast mode.

Comment 1

[David Olah]

Attachment: CB_High_Contrast.png

Comment 2

[(no longer active)]

This isn't a Core bug?

Comment 3

[Andrea Marchesini [:baku]]

Right. Firefox preferences is better.

Comment 4

[Erica Wright [:ewright]]

Attachment: Bug 1518807 - Icons and images are visible on high contrast mode.

High contrast mode does not render background images, set as list-style image instead. Fix fill colors for other icons.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a2fee54f94
Icons and images are visible on high contrast mode. r=jaws

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/01a2fee54f94

Comment 7

[Pascal Chevrel:pascalc]

This small CSS patch looks contained and safe and fixes an obvious visual bug with high-contrast themes, Erica do you want to request an uplift to 67 Beta or do you prefer to let it ride the trains to 68?

Comment 8

[Erica Wright [:ewright]]

Sure, I can request uplift.

Comment 9

[Erica Wright [:ewright]]

Comment on attachment 9051839 [details]
Bug 1518807 - Icons and images are visible on high contrast mode.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1501985
• User impact if declined: in high contrast mode, icons are not visible in about:preferences#privacy section.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): just css change
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9051839 [details]
Bug 1518807 - Icons and images are visible on high contrast mode.

Safe patch for a visible bug in high contrast mode, uplift approved for 67 beta 7, thanks.

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f97ab548d6f1

Comment 12

[Ciprian Georgiu, Desktop QA]

I verified this issue on latest Nightly 68.0a1 (20190407214820) using Windows 7 x64, but it seems that some icons are still not displayed in about:preferences when High Contrast mode is applied. In "Standard" and "Strict" mode the icons are missing for "Known trackers only in Private Windows" and "Third-party tracking cookies"; please observe the image.

Any thoughts about this, Erica?

Comment 13

[Erica Wright [:ewright]]

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #12)

I verified this issue on latest Nightly 68.0a1 (20190407214820) using Windows 7 x64, but it seems that some icons are still not displayed in about:preferences when High Contrast mode is applied. In "Standard" and "Strict" mode the icons are missing for "Known trackers only in Private Windows" and "Third-party tracking cookies"; please observe the image.

Any thoughts about this, Erica?

looks like I missed them, Another note, the chevron up and down were also missed.