1518921 - Discovery Stream Spocs

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

New spoc functionality has spoc endpoint being returned from the layout.

It's a single list and needs to be fetched, cached, and put into redux, similar to feeds.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4649

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4811af89779ce7551f361379298f1856201c551b
Fixes bug 1518921 - Discovery Stream Spocs (#4649)

* Fixes bug 1518921 - Discovery Stream Spocs

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8de26a67ac5c

Comment 4

[Brahmini Nagabandi]

Hi,

Any updates on QA steps?

Comment 5

[Scott [:thecount] Downe]

It might be tricky to know what's a spoc and what's not, as the data might change. At the time I wrote this spocs are about credit cards. I might take the time to make a fake spoc response so it won't change.

1. set your browser.newtabpage.activity-stream.discoverystream.config pref to {"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/1be633daea7d1ce65a8ca903a3be9ae9/raw/3d51663327126879f6fa1c6b3e7730e7805c9e1e/spocs"}
2. Load a new tab, take note of the 3rd card in both the card grid and hero grid.
3. Refresh a couple times, noting the 3rd card in each refresh.

Expected: The third position on each hero and card component has a 50% chance to be a spoc.

There are 4 combinations based on the rolls you get.

1. where both rolls fail, and in this case you see the same card in both positions in both components because they share the same feed.

2. where the card component rolls a spoc and the hero does not.

3. where hero has a spoc and card doesn't.

4. And finally where they both have spocs.

Comment 6

[Brahmini Nagabandi]

QA Results :

Tested on :

FF Nightly version : 66.0a1 (2019-01-18)

OS : Mac

Works as expected.

Result can be found here :

Recording : https://www.dropbox.com/s/y3oab5kbtgc6fgs/bug%201518921.mp4?dl=0

Closing as verified.