1518947 - Update breakpad to include the latest Windows/Aarch64 fixes

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1513284 +++

Upstream breakpad has been landing some Windows/AArch64-specific fixes. We should update our code to include version b988fa74ec18de6214b18f723e48331d9a7802ae. Since some of the changes are in the client code this will require applying them manually.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1518947 - Update breakpad to revision 44384d80b32a5bb361c2ec3bee667f7ccee566d7

This includes some assorted fixes from upstream plus an adaptation of the
patch in b988fa74ec18de6214b18f723e48331d9a7802ae which includes heap memory
regions in the minidump. Since our support for that is more extensive than
upstream breakpad the resulting change reflects this. Last but not least the
fixes for bug 1489094 and bug 1511140 were split out as patches to be applied
to the unmodified breakpad sources. They will be reintegrated as soon as we
fork breakpad for good.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27334525afa6
Update breakpad to revision 44384d80b32a5bb361c2ec3bee667f7ccee566d7 r=ted

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/27334525afa6

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9035951 [details]
Bug 1518947 - Update breakpad to revision 44384d80b32a5bb361c2ec3bee667f7ccee566d7

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

New functionality

User impact if declined

Crash reports / crash pings for Windows/AArch64 might not contain all the data we require. This is not visible by the user but will affect developers.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The change adds a very small amount of code to Gecko to to gather information that is appended to the crash reporter. This just enables some common functionality that's already supported on other architectures and works well. The rest of the changes go into the minidump-analyzer tool which is run outside of Gecko. Both of these bits are already covered by tests.

String changes made/needed

None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9035951 [details]
Bug 1518947 - Update breakpad to revision 44384d80b32a5bb361c2ec3bee667f7ccee566d7

We want good crash data; let's uplift for beta 6.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c916c1117a67