Closed Bug 1518964 Opened 2 years ago Closed 2 years ago

Make simplified SchemeIs methods on nsIURI (SchemeIsHTTP, SchemeIsHTTPS, etc...)

Categories

(Core :: Networking, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Ballparking from looking at searchfox (https://searchfox.org/mozilla-central/search?q=SchemeIs&path=), something like 80% of our SchemeIs calls are for http, https, chrome, about, and a few other types. We can just tack methods onto nsIURI for these specific cases to clean up code, versus having to pass protocol strings everywhere.

Whiteboard: [necko-triaged]
Create conveinence functions for common protocols used in SchemeIs
queries.

:valentin I just copied over the SchemeIs functions from bug 1518956. I can reduce the amount of protocols supported by these convenience functions if you think this list is still overkill.

Attachment #9035716 - Attachment description: Bug 1518964 - Add SchemeIs conveinence functions; → Bug 1518964 - Add SchemeIs convenience functions;
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d288304b11fa
Add SchemeIs convenience functions; r=valentin
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.