Closed
Bug 1518964
Opened 6 years ago
Closed 6 years ago
Make simplified SchemeIs methods on nsIURI (SchemeIsHTTP, SchemeIsHTTPS, etc...)
Categories
(Core :: Networking, enhancement, P4)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
Ballparking from looking at searchfox (https://searchfox.org/mozilla-central/search?q=SchemeIs&path=), something like 80% of our SchemeIs calls are for http, https, chrome, about, and a few other types. We can just tack methods onto nsIURI for these specific cases to clean up code, versus having to pass protocol strings everywhere.
|
||
Updated•6 years ago
|
Whiteboard: [necko-triaged]
|
Assignee | |
Comment 1•6 years ago
|
||
Create conveinence functions for common protocols used in SchemeIs
queries.
|
|
Assignee | |
Comment 2•6 years ago
|
||
:valentin I just copied over the SchemeIs functions from bug 1518956. I can reduce the amount of protocols supported by these convenience functions if you think this list is still overkill.
|
||
Updated•6 years ago
|
Attachment #9035716 -
Attachment description: Bug 1518964 - Add SchemeIs conveinence functions; → Bug 1518964 - Add SchemeIs convenience functions;
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d288304b11fa
Add SchemeIs convenience functions; r=valentin
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•