1519018 - Remove DevTools onboarding experiment code

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

We already decided to not use a page for devtools onboarding, so now that the experiment is finished we should remove the code.

Comment 7

[Julian Descottes [:jdescottes]]

Had a quick look and the main issue here is that we have a significant amount of logic that supports "disabled devtools" (eg new menu item "Enable Developer Tools..."). So if we remove the about:devtools page, in theory we should remove everything that might lead to about:devtools, otherwise we will have dead code paths. But a lot of that might be reusable for future onboarding experiments, so I think it would be a waste to throw all the code away.

We can try to cleanup things related to the onboarding experiment from 2018 and simplify the page in a first iteration.

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1519018 - Remove startup code dedicated for DevTools onboarding experiment

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1519018 - Remove expired scalar devtools.onboarding.is_devtools_user

Depends on D38167

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1519018 - Remove expired scalars and histograms related to about:devtools page

Depends on D38168

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/407b0e3db691
Remove startup code dedicated for DevTools onboarding experiment r=ochameau
https://hg.mozilla.org/integration/autoland/rev/29cfda7f1700
Remove expired scalar devtools.onboarding.is_devtools_user r=ochameau,janerik
https://hg.mozilla.org/integration/autoland/rev/3d2f60121e46
Remove expired scalars and histograms related to about:devtools page r=ochameau,janerik

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/407b0e3db691
https://hg.mozilla.org/mozilla-central/rev/29cfda7f1700
https://hg.mozilla.org/mozilla-central/rev/3d2f60121e46

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jdescottes, maybe it's time to close this bug?