151907 - need to remove accidental check in of slower code

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Frank Tang]

somehow Mar 12 14:36 I accidentially land code which does not r=/sr= in 

mozilla/ gfx/ src/ mac/ nsUnicodeRenderingToolkit.cpp (1.33)
the 

  Point   penLoc;                                                               
  ::GetPen(&penLoc);                                                            
  oWidth = penLoc.h - x;                                                        
somehow got replaced by my experiemental code
  oWidth = ::TextWidth(buf, 0, aLen);        

We should change it back because TextWidth is slower                           
         

This change do not have any impact on the prescion of the measurement but have
impact on performance

Comment 1

[Frank Tang]

reassign to nhotta. naoki, thank you thank you thank you thank  you...

Comment 2

[nhottanscp]

Attachment: Cowtool result optimized Carbon branch build

Comment 3

[nhottanscp]

Attachment: Cowtool result optimized Carbon branch build, removed the accidental checkin

Comment 4

[nhottanscp]

Attachment: patch to remove the unintended check in

Comment 5

[nhottanscp]

Result without the patch
Avg. Median : 961 msec		Minimum     : 347 msec
Average     : 977 msec		Maximum     : 2890 msec

Result with the patch
Avg. Median : 963 msec		Minimum     : 397 msec
Average     : 978 msec		Maximum     : 2844 msec

Comment 6

[Greg K.]

Would this be better in Layout or Internationalization than Browser-General?

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 88551 [details] [diff] [review]
patch to remove the unintended check in

sr=sfraser

Comment 8

[Simon Fraser [no longer active]]

Moving bug to the GFX component.

Comment 9

[Frank Tang]

the bit question is should we check this into branch ? Is that worthy with the
number here ? We should land into trunk for sure. 

Comment 10

[Frank Tang]

Comment on attachment 88551 [details] [diff] [review]
patch to remove the unintended check in

let's land this into trunk and forget about branch

Comment 11

[nhottanscp]

checked in to the trunk