need to remove accidental check in of slower code

RESOLVED FIXED

Status

defect
RESOLVED FIXED
17 years ago
11 years ago

People

(Reporter: ftang, Assigned: nhottanscp)

Tracking

({intl})

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(3 attachments)

Reporter

Description

17 years ago
somehow Mar 12 14:36 I accidentially land code which does not r=/sr= in 

mozilla/ gfx/ src/ mac/ nsUnicodeRenderingToolkit.cpp (1.33)
the 

  Point   penLoc;                                                               
  ::GetPen(&penLoc);                                                            
  oWidth = penLoc.h - x;                                                        
somehow got replaced by my experiemental code
  oWidth = ::TextWidth(buf, 0, aLen);        

We should change it back because TextWidth is slower                           
         

This change do not have any impact on the prescion of the measurement but have
impact on performance
Reporter

Updated

17 years ago
Blocks: 141008
Keywords: intl, nsbeta1+
Reporter

Comment 1

17 years ago
reassign to nhotta. naoki, thank you thank you thank you thank  you...
Assignee: ftang → nhotta
Assignee

Comment 5

17 years ago
Result without the patch
Avg. Median : 961 msec		Minimum     : 347 msec
Average     : 977 msec		Maximum     : 2890 msec

Result with the patch
Avg. Median : 963 msec		Minimum     : 397 msec
Average     : 978 msec		Maximum     : 2844 msec

Comment 6

17 years ago
Would this be better in Layout or Internationalization than Browser-General?
Comment on attachment 88551 [details] [diff] [review]
patch to remove the unintended check in

sr=sfraser
Attachment #88551 - Flags: superreview+
Moving bug to the GFX component.
Component: Browser-General → GFX Compositor
Reporter

Comment 9

17 years ago
the bit question is should we check this into branch ? Is that worthy with the
number here ? We should land into trunk for sure. 
Reporter

Comment 10

17 years ago
Comment on attachment 88551 [details] [diff] [review]
patch to remove the unintended check in

let's land this into trunk and forget about branch
Attachment #88551 - Flags: review+
Assignee

Comment 11

17 years ago
checked in to the trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.