151909 - X-remote does not distinguish between profiles

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Andrew Schultz]

If you use X-remote commands with two or more Mozilla profiles (same user) open
on the same display, X-remote cannot distinguish between them and performs
operations on whichever window was used last.

This would help to ensure a proper implementation of bug 122698 and would also
help resolve problems in bug 151863.

Comment 1

[Andrew Schultz]

Attachment: patch

patch that works.
there might be a better way to do GetCurrentProfile.  I just stole that from
nsAppShellService.cpp

Comment 2

[Andrew Schultz]

Attachment: patch including gtk2

patch includes gtk2.  I haven't tested with gtk2, but the relevant parts of the
code are identical.

Comment 3

[Andrew Schultz]

Blizzard, could you review the patch (or WONTFIX this bug :()

thanks

Comment 4

[Thomas F. O'Connell]

This is a pretty frustrating bug for anyone on GNU/Linux using a Mozilla-based
browser to open URLs from other applications. There's a patch posted. Is there
any hope of speeding up the review process?

Comment 5

[Andrew Hagen]

Patch exists.

Comment 6

[Christopher Blizzard (:blizzard)]

Not blocking 1.4.

Comment 7

[Vaclav Dvorak]

As Christopher Blizzard seems to be too busy for this, is there anyone else who
could do the review? Thanks. Although this bug in itself is probably not very
visible, it's supposedly blocking bug 122698 which is a PITA for virtually
everyone on Unix.

Comment 8

[alanjstr]

Has this patch bitrotted at al?

Comment 9

[Christopher Blizzard (:blizzard)]

We're about to make some changes to the xremote code to handle firebird/tbird
changes.

Comment 10

[Christopher Blizzard (:blizzard)]

Patch in bug 237283 fixed this.