1519102 - Network Events are modified by webConsole

Status: RESOLVED INVALID

(DevTools :: Netmonitor, enhancement, P3)

Description

[Yulia Startsev [:yulia]]

The webconsole modifies the shape of the networkEvent form:

https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/client.js#102-125

Most of this data is available but not sent in the form:

https://searchfox.org/mozilla-central/source/devtools/server/actors/network-event.js#56-71

It doesn't make much sense to be doing this kind of adjustment client side, and it makes it more difficult to manage the events once this becomes a protocol.js front. These should be reconciled

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1519102 - remove timeout in debugger navigated action; r=ochameau

this removes the timeout from the debugger navigated action, and resolves the test case. This isn't
a full solution, we probably still need a "reloaded event as recommended by ochameau

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1519102 - add onReload event to navigated action; r=ochameau

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1519102 - update networkEvent form() to return the fields used by the client; r=ochameau

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1519102 - do not change shape of packet when console reemits networkEvent; r=ochameau

This patch aligns the data structure of the event emitted by the webclientConsole on networkEvent
to something that can be reconciled with the event emitted by the NetEvent Actor for the event of
the same name. It also brings it close to the shape of the networkUpdate event. The plan is to
modify the packet emitted by the NetEvent actor with a before call, and just attach the
networkInfo object to it.

Comment 5

[Yulia Startsev [:yulia]]

closing as no longer necessary for fission.