Open Bug 1519132 Opened 10 months ago Updated 5 months ago

[Track changes] - Declaration values containing quotes are not properly picked up by the changes tab

Categories

(DevTools :: Inspector: Changes, defect, P2)

defect

Tracking

(firefox65 wontfix, firefox66 wontfix, firefox67 wontfix, firefox68 wontfix)

Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix

People

(Reporter: JuliaC, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Affected versions

  • 66.0a1 (2019-01-10)
  • 65.0b9 build1 (20190107180200)

Affected platforms

  • Windows 10 x64
  • macOS 10.13.6
  • Ubuntu 16.04 x64

Steps to reproduce

  1. Launch Firefox (and make sure that "devtools.inspector.changes.enabled" is set to "true" in about:config)
  2. Open a random website
  3. Right click on any element and select the "Inspect Element" context menu option
  4. Choose a selector from the Rules panel and add a new declaration inside it, making sure its value contains quotes (e.g. font-family: "Fira Sans"; )
  5. Inspect the Changes tab

Expected result

  • The newly added declaration is properly tracked and displayed inside the Changes tab

Actual result

  • Changes tab generates a new entry for every character contained between the quotes

Regression range

Additional notes

Forgot to mention the following behaviour: when starting to delete the value introduced in step 4, only the last related entry from the Changes tab is deleted.

Good catch. Thanks for filing! This likely never worked correctly.

A reduced test case:

  • Paste this in the address bar:
data:text/html,<style>div{font-family: "Font Name"}</style><div>TEST
  • Open DevTools and inspect the <div>
  • From the Rules panel, repeatedly delete characters from the end of the font-family value, including the ending quote
  • Observe the Changes panel
Priority: -- → P2

rcaliman, can we prioritize fixing this considering it's a new feature for 65?

Flags: needinfo?(rcaliman)

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #3)

rcaliman, can we prioritize fixing this considering it's a new feature for 65?

Looking into this issue reveals that the cause lies upstream from the Changes panel in the way the CSS rule rewriter tries to guard against the malformed string. The fix is not trivial and I believe it's risky to attempt to uplift this now. I'd opt for taking time to properly investigate a solution, test it, then let it either ride the trains or uplift when confident.

Flags: needinfo?(rcaliman) → needinfo?(jaws)
Has Regression Range: --- → yes
Component: Inspector → Inspector: Changes

Hey Razvan, does your analysis in comment 4 still stands? If so, I think we should mark this as wontfix for Firefox 67.

Flags: needinfo?(rcaliman)

Yes, this still needs poking upstream from the Changes panel. I'll mark this as wontfix for Firefox 67 with a potential fix coming during the Firefox 68 cycle. If it's safe to uplift, we'll consider it then.

Flags: needinfo?(rcaliman)

Hi Razvan, are you still planning a fix for 68?

Flags: needinfo?(razvan.ragazan)

Wrong Razvan needinfo?-ed :)

There won't be a fix for this in the Firefox 68 cycle. I will update the tracking flags.

Flags: needinfo?(razvan.ragazan)

Oops. And thanks :)

You need to log in before you can comment on or make changes to this bug.