1519160 - Middle click on the Tabs Bar does not create a new tab

Status: VERIFIED FIXED

(Toolkit :: XUL Widgets, defect, P2)

Description

[Dan Ceban [:okazki98]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. Middle click on empty space on the tabs bar.

Actual results:

Clicking with the mouse wheel does not create a new tab. Anywhere else the middle click actions are working as expected (e.g clicking on a link to open in a new tab, closing tabs, opening parent tab clone when middle clicking on the "New tab" button).

Only the 66 branch is affected. Release and Beta are working as expected.

Expected results:

When middle clicking create a new tab.

Comment 1

[Gingerbread Man]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b21a65e29e757f22e297f75ab2e8dfe43ca747bc&tochange=3e99aed6c14d423119aebd1cb2214f3270008faf

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks for filing. It's pretty sad that there wasn't a test...

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The feature broke was bug 573438.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1519160 - Restore middle click & double click on tabstrip to open new tabs r=dao

Wich the scrollbox binding gone the tag name to check should be "scrollbox" instead of "box".

Comment 5

[Radomir]

Same here, just wanted to post it. Replying here to follow.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd2b5b6a3048
Restore middle click & double click on tabstrip to open new tabs r=dao

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fd2b5b6a3048

Comment 8

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Confirmed the issue with 66.0a1 (2019-01-10) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.11.6.
Fix verified with 66.0b3 build1 (20190128143734), Windows 10 x64, Ubuntu 18.04 x64, macOS 10.11.6.
I have a misunderstanding though - the free space that remains before the minimize button when having multiple opened tabs cannot be used for creating a new tab by middle clicking. Is this intended?

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I believe so, but the best way to be sure is to open up an unaffected version and compare their behaviors. The fix here is intended to restore the behavior to what the unaffected version does.

If that little space seems confusing and should open a new tab when middle-clicked, that's probably another bug.

Comment 10

[Bodea Daniel [:danibodea]]

The behavior mentioned by Iulia in comment 8 is the same on affected builds and one after the fix. My personal opinion is that it's intended. I will set this bug as verified based on the testing above + testing in latest Nightly (v69.0a1 from 2019-06-06) and the current release (v67.0.1).
Thank you!

Comment 11

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Since it has been verified for nightly and release, is it verified for beta too?
For more information, please visit auto_nag documentation.

Comment 12

[Bodea Daniel [:danibodea]]

Also verified Beta v68.0b8.