Implement the Temporal proposal
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
People
(Reporter: alex.fdm, Assigned: anba)
References
(Blocks 2 open bugs, )
Details
(Keywords: dev-doc-needed)
Attachments
(7 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
The proposal is currently in Stage 2.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Taking for now because I've already written some code.
This is currently blocked from shipping unflagged on IETF Standardization work: https://github.com/tc39/proposal-temporal/issues/1450
Assignee | ||
Comment 4•2 years ago
|
||
FWIW, I have a local prototype which includes everything from the current proposal apart from https://tc39.es/proposal-temporal/#sec-temporal-legacy-date-objects and https://tc39.es/proposal-temporal/#sec-temporal-intl. Unsurprisingly a proposal as large as Temporal
has numerous issues, I've already filed some at https://github.com/tc39/proposal-temporal/issues/1502, but in the meantime I've found more issues. (There are more than 350 FIXME and TODO annotations referring to spec issues in that prototype.) My current plan is to wait until the spec authors have addressed this feedback before I'll upload the patches for review, because I don't think it makes sense to spend time reviewing code which is still so volatile. And waiting a bit longer gives me additional time to clean-up the code, add comments, etc. :-)
Assignee | ||
Comment 5•2 years ago
|
||
In its current form, without any optimisations or overly large comments except spec-step comments, the number of lines already exceeds "builtin/intl", so reviewers will have their, err..., fun! :-)
~/hg/mozilla-inbound$ LANG=C wc -l js/src/builtin/temporal/*
2819 js/src/builtin/temporal/Calendar.cpp
149 js/src/builtin/temporal/Calendar.h
5500 js/src/builtin/temporal/Duration.cpp
107 js/src/builtin/temporal/Duration.h
2006 js/src/builtin/temporal/Instant.cpp
80 js/src/builtin/temporal/Instant.h
35 js/src/builtin/temporal/moz.build
2419 js/src/builtin/temporal/PlainDate.cpp
85 js/src/builtin/temporal/PlainDate.h
2940 js/src/builtin/temporal/PlainDateTime.cpp
110 js/src/builtin/temporal/PlainDateTime.h
1174 js/src/builtin/temporal/PlainMonthDay.cpp
58 js/src/builtin/temporal/PlainMonthDay.h
2277 js/src/builtin/temporal/PlainTime.cpp
84 js/src/builtin/temporal/PlainTime.h
1943 js/src/builtin/temporal/PlainYearMonth.cpp
59 js/src/builtin/temporal/PlainYearMonth.h
2558 js/src/builtin/temporal/Temporal.cpp
334 js/src/builtin/temporal/Temporal.h
494 js/src/builtin/temporal/TemporalNow.cpp
31 js/src/builtin/temporal/TemporalNow.h
2584 js/src/builtin/temporal/TemporalParser.cpp
61 js/src/builtin/temporal/TemporalParser.h
76 js/src/builtin/temporal/TemporalTypes.h
67 js/src/builtin/temporal/TemporalTypes-inl.h
1912 js/src/builtin/temporal/TimeZone.cpp
96 js/src/builtin/temporal/TimeZone.h
22 js/src/builtin/temporal/Wrapped.cpp
183 js/src/builtin/temporal/Wrapped.h
3902 js/src/builtin/temporal/ZonedDateTime.cpp
131 js/src/builtin/temporal/ZonedDateTime.h
34296 total
Wow, amazing stuff. Can't wait to review ;) maybe we can have a couple of us do it..
Assignee | ||
Comment 7•1 year ago
|
||
Assignee | ||
Comment 8•1 year ago
|
||
Depends on D124224
Assignee | ||
Comment 9•1 year ago
|
||
Depends on D124225
Assignee | ||
Comment 10•1 year ago
|
||
Depends on D124226
Assignee | ||
Comment 11•1 year ago
|
||
This is the current prototype, not yet ready for review. There is currently one large patch which covers the whole proposal, for review it will be split into smaller, reviewable parts. The --with-temporal-api
flag must be set in the "mozconfig" resp. passed to configure
to enable the Temporal code.
Assignee | ||
Comment 12•7 months ago
|
||
Temporal.TimeZone
needs these additional methods.
Updated•7 months ago
|
Updated•7 months ago
|
Updated•7 months ago
|
Assignee | ||
Comment 13•7 months ago
|
||
Depends on D124226
Updated•7 months ago
|
Assignee | ||
Comment 14•7 months ago
|
||
Depends on D124227
Updated•4 months ago
|
Description
•