1519226 - Intermittent browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | Test timed out -

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: dvarga [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=221160878&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/cdrJcNPNSiSDGYGc4Hxnsw/runs/0/artifacts/public/logs/live_backing.log

[task 2019-01-10T20:28:30.746Z] 20:28:30 INFO - TEST-START | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js
[task 2019-01-10T20:29:15.828Z] 20:29:15 INFO - TEST-INFO | started process screentopng
[task 2019-01-10T20:29:16.549Z] 20:29:16 INFO - TEST-INFO | screentopng: exit 0
[task 2019-01-10T20:29:16.549Z] 20:29:16 INFO - Buffered messages logged at 20:28:30
[task 2019-01-10T20:29:16.550Z] 20:29:16 INFO - Entering test bound testAppMenuButtonPress
[task 2019-01-10T20:29:16.553Z] 20:29:16 INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 869}]
[task 2019-01-10T20:29:16.553Z] 20:29:16 INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 869}]
[task 2019-01-10T20:29:16.553Z] 20:29:16 INFO - Buffered messages finished
[task 2019-01-10T20:29:16.554Z] 20:29:16 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | Test timed out -
[task 2019-01-10T20:29:16.557Z] 20:29:16 INFO - GECKO(1511) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-01-10T20:29:16.558Z] 20:29:16 INFO - GECKO(1511) | MEMORY STAT | vsize 1824MB | residentFast 264MB | heapAllocated 79MB
[task 2019-01-10T20:29:16.559Z] 20:29:16 INFO - TEST-OK | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | took 45099ms
[task 2019-01-10T20:29:16.560Z] 20:29:16 INFO - checking window state
[task 2019-01-10T20:29:17.447Z] 20:29:17 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1769
[task 2019-01-10T20:29:17.506Z] 20:29:17 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1684
[task 2019-01-10T20:29:17.507Z] 20:29:17 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1603
[task 2019-01-10T20:29:17.508Z] 20:29:17 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1625
[task 2019-01-10T20:29:17.509Z] 20:29:17 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1715
[task 2019-01-10T20:29:17.791Z] 20:29:17 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1511

Comment 1

[Intermittent Failures Robot]

1 failures in 2627 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-01-07&endday=2019-01-13&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 2378 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-01-14&endday=2019-01-20&tree=all

Comment 3

[Intermittent Failures Robot]

1 failures in 2383 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-01-21&endday=2019-01-27&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 2628 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-01-28&endday=2019-02-03&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 2658 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-04&endday=2019-02-10&tree=all

Comment 6

[Intermittent Failures Robot]

31 failures in 471 pushes (0.066 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 6
• try: 9
• mozilla-inbound: 6
• autoland: 10

Platform breakdown:

• windows7-32: 1
• osx-10-10: 6
• linux64: 9
• linux64-ccov: 1
• linux32: 14

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-14&endday=2019-02-14&tree=all

Comment 7

[Intermittent Failures Robot]

26 failures in 588 pushes (0.044 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• mozilla-central: 5
• mozilla-inbound: 7
• try: 1

Platform breakdown:

• osx-10-10: 9
• linux32: 6
• linux64: 9
• linux64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-15&endday=2019-02-15&tree=all

Comment 8

[Intermittent Failures Robot]

20 failures in 121 pushes (0.165 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 7
• autoland: 8
• mozilla-central: 5

Platform breakdown:

• linux32: 9
• windows10-64-ccov: 1
• linux64-ccov: 1
• osx-10-10: 1
• linux32-nightly: 1
• linux64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-16&endday=2019-02-16&tree=all

Comment 9

[Intermittent Failures Robot]

96 failures in 2832 pushes (0.034 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 39
• mozilla-inbound: 22
• try: 16
• mozilla-central: 19

Platform breakdown:

• linux64: 35
• windows7-32: 1
• linux32-nightly: 1
• linux64-ccov: 5
• linux32: 34
• osx-10-10: 19
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-11&endday=2019-02-17&tree=all

Comment 10

[:Gijs (he/him)]

Jamie, could you take a look please? Looks like this test has become a high prio intermittent at this point (see comment #9)

Comment 11

[:Gijs (he/him)]

Joel, why didn't this get flagged up to someone as stockwell:needsowner?

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

gijs, this only started failing since February 14th. I am not sure why there wasn't a stockwell tag on this, I agree that looks invalid.

Comment 13

[Intermittent Failures Robot]

33 failures in 501 pushes (0.066 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 2
• mozilla-central: 9
• mozilla-inbound: 6
• autoland: 16

Platform breakdown:

• linux64: 18
• linux64-ccov: 1
• osx-10-10: 3
• linux32: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-19&endday=2019-02-19&tree=all

Comment 14

[Intermittent Failures Robot]

17 failures in 425 pushes (0.04 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 7
• mozilla-inbound: 4
• mozilla-central: 3
• try: 3

Platform breakdown:

• linux32: 5
• osx-10-10: 5
• linux64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-20&endday=2019-02-20&tree=all

Comment 15

[James Teh [:Jamie]]

For the record, I am working on this, but am not having much luck so far. On Linux and Mac (but not Windows), focusing and pressing space on the Bookmark This page button (#star-button) in the test just does nothing sometimes. I've confirmed that the button is visible, that the button definitely has focus, that focus isn't getting yanked away by something else (by waiting 2 seconds and checking focus again), and that the "Show editor when saving" option is checked.

Comment 16

[:Gijs (he/him)]

(In reply to James Teh [:Jamie] from comment #15)

For the record, I am working on this, but am not having much luck so far. On Linux and Mac (but not Windows), focusing and pressing space on the Bookmark This page button (#star-button) in the test just does nothing sometimes. I've confirmed that the button is visible, that the button definitely has focus, that focus isn't getting yanked away by something else (by waiting 2 seconds and checking focus again), and that the "Show editor when saving" option is checked.

Have you tried adding a popuphidden listener to the popup and see if it fires when trying to open it? This is what seems to be happening in bug 1396196 (linux intermittent in browser_editcontrols_update.js ). Basically, something (in that bug, a focus change notification from the OS) trips some xul popup code while the popup is being opened, and closes it immediately, leading to the impression that it "does nothing".

Comment 17

[James Teh [:Jamie]]

I added this code before sending the key press:

    let onHidden = evt => info("jtd panel hidden");
    panel.addEventListener("popuphidden", onHidden);

After the key press, I wait for 2 seconds (via setTimeout). However, the "jtd panel hidden" never appears in the output. So, I guess that means it isn't getting fired?

Frustratingly, I just added a whole bunch of debug logging to the actual UI code... and with that, the bug magically goes away. 😬 I'll keep chipping away at it.

Comment 18

[Intermittent Failures Robot]

38 failures in 597 pushes (0.064 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 18
• mozilla-central: 7
• try: 5
• mozilla-inbound: 8

Platform breakdown:

• osx-10-10: 4
• linux64: 19
• linux32: 12
• linux64-ccov: 2
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-21&endday=2019-02-21&tree=all

Comment 19

[Andreea Pavel [:apavel]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #12)

gijs, this only started failing since February 14th. I am not sure why there wasn't a stockwell tag on this, I agree that looks invalid.

Up until now, as it has the [stockwell disable-recommended] this did not appear in the fresh or neglected oranges list.

Comment 20

[Andreea Pavel [:apavel]]

There are 147 total failures in the last 7 days, on linux, win and osx.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230005636&repo=autoland&lineNumber=2919

[task 2019-02-23T00:23:42.093Z] 00:23:42 INFO - TEST-START | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js
[task 2019-02-23T00:23:42.101Z] 00:23:42 INFO - GECKO(1791) | Chrome file doesn't exist: /builds/worker/workspace/build/tests/mochitest/browser/browser/base/content/test/keyboard/head.js
[task 2019-02-23T00:23:42.253Z] 00:23:42 INFO - GECKO(1791) | [Parent 1791, Main Thread] WARNING: '!parent', file /builds/worker/workspace/build/src/netwerk

[task 2019-02-23T00:25:12.768Z] 00:25:12 INFO - TEST-PASS | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | Sidebar hidden after press -
[task 2019-02-23T00:25:12.768Z] 00:25:12 INFO - Leaving test bound testSidebarsButtonPress
[task 2019-02-23T00:25:12.769Z] 00:25:12 INFO - Entering test bound testBookmarkButtonPress
[task 2019-02-23T00:25:12.769Z] 00:25:12 INFO - Buffered messages finished
[task 2019-02-23T00:25:12.770Z] 00:25:12 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | Test timed out -
[task 2019-02-23T00:25:12.770Z] 00:25:12 INFO - GECKO(1791) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-02-23T00:25:12.774Z] 00:25:12 INFO - GECKO(1791) | MEMORY STAT | vsize 1949MB | residentFast 311MB | heapAllocated 81MB
[task 2019-02-23T00:25:12.778Z] 00:25:12 INFO - TEST-OK | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | took 90089ms
[task 2019-02-23T00:25:12.778Z] 00:25:12 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-02-23T00:25:12.778Z] 00:25:12 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | Found a tab after previous test timed out: https://example.com/ -
[task 2019-02-23T00:25:12.782Z] 00:25:12 INFO - GECKO(1791) | ++DOCSHELL 0x7feea6e9c000 == 1 [pid = 2118] [id = {f962cc04-420a-4fd3-a32e-538e19b2b21b}]
[task 2019-02-23T00:25:12.782Z] 00:25:12 INFO - checking window state
[task 2019-02-23T00:25:12.786Z] 00:25:12 INFO - GECKO(1791) | ++DOMWINDOW == 1 (0x7feea6e39c00) [pid = 2118] [serial = 1] [outer = (nil)]

James, since you are working on the bug, I'm removing the disable recommended bug and adding the needswork:owner one.

Comment 21

[Intermittent Failures Robot]

35 failures in 500 pushes (0.07 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• mozilla-inbound: 2
• autoland: 23
• try: 6
• mozilla-central: 4

Platform breakdown:

• linux32: 14
• linux64: 16
• osx-10-10: 4
• linux64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-22&endday=2019-02-22&tree=all

Comment 22

[Intermittent Failures Robot]

166 failures in 2602 pushes (0.064 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 86
• try: 19
• mozilla-inbound: 28
• mozilla-central: 33

Platform breakdown:

• linux32: 66
• linux64: 74
• osx-10-10: 19
• linux64-ccov: 6
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-18&endday=2019-02-24&tree=all

Comment 23

[James Teh [:Jamie]]

After days of exasperation, I think I've finally figured out what's going on here. Testing the fix at the moment.

Comment 24

[James Teh [:Jamie]]

Attachment: Bug 1519226: browser_toolbarButtonKeyPress.js: Wait for the bookmarked status to finish updating before pressing the Bookmark this page button.

The status regarding whether a page is bookmarked or not is updated async.
While the update is pending, the Bookmark this page button ignores activation.
Thus, the test must wait for the update to be finished before trying to press the button.
This fixes intermittent timeouts in this test.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4c45ebf34ac
browser_toolbarButtonKeyPress.js: Wait for the bookmarked status to finish updating before pressing the Bookmark this page button. r=Gijs

Comment 26

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f4c45ebf34ac

Comment 27

[Intermittent Failures Robot]

13 failures in 2981 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 5
• try: 2
• mozilla-inbound: 1

Platform breakdown:

• linux32: 6
• linux64: 2
• osx-10-10: 3
• linux64-ccov: 1
• linux32-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-02-25&endday=2019-03-03&tree=all

Comment 28

[Andreea Pavel [:apavel]]

This is still occurring: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231705402&repo=autoland&lineNumber=1633

James, should I file a new bug or reopen this?

Comment 29

[James Teh [:Jamie]]

It seems this is a failure in a different subtest (testAppMenuButtonPress vs testBookmarkButtonPress). I believe the latter (testBookmarkButtonPress) was a much more regular failure, which is why this became high priority in comment 9 after bug 1436086 landed (which introduced that test). That's the one I've fixed here. I think the reason this bug was originally filed was the former (testAppMenuButtonPress) and it seems that one hasn't gone away.

I'd prefer to have a new bug for this testappMenuButtonPress failure, as this bug now has a lot of history relating to the test that is now fixed.

Thanks!

Comment 30

[Andreea Pavel [:apavel]]

Filed bug 1532501. Thanks James.

Comment 31

[Intermittent Failures Robot]

1 failures in 2818 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519226&startday=2019-03-04&endday=2019-03-10&tree=all

Comment 32

[Edgar Chen [:edgar]]

Attachment: Bug 1519226 - Wait for the bookmarked status to finish updating before starting test; r?Gijs

The Bookmark page button ignores activation if there is pending update. Thus,
the test must wait for the update to be finished before synthesizing mouse
actions.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c1092771230
Wait for the bookmarked status to finish updating before starting test; r=Gijs

Comment 34

[Phabricator Automation]

Comment on attachment 9140900 [details]
Bug 1519226 - Wait for the bookmarked status to finish updating before starting test; r?Gijs

Revision D71114 was moved to bug 1385882. Setting attachment 9140900 [details] to obsolete.

Comment 35

[:Gijs (he/him)]

(In reply to Pulsebot from comment #33)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c1092771230
Wait for the bookmarked status to finish updating before starting test;
r=Gijs

Sorry, this should have landed pointing to bug 1385882 instead.

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33958bd042bf
Backed out changeset 5c1092771230 for landing with wrong bug number on a CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/bebf14fcc0e2
Wait for the bookmarked status to finish updating before starting test; r=Gijs CLOSED TREE DONTBUILD

Comment 37

[Andreea Pavel [:apavel]]

Backed out for landing with wrong bug number, relanded with correct bug no.

Comment 38

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7920149150d0
Backed out changeset bebf14fcc0e2 bug number not updated CLOSED TREE