1519289 - Remove usage of signature_hash in Perfherder

Status: NEW

(Tree Management :: Perfherder, enhancement, P3)

Description

[Sarah Clements [:sclements]]

Per a conversation with :wlach, the usage of signature_hash should be deprecated and removed in Perfherder - in the graphs controller and comparesubtestdistribution replicates controller. However, this might require versioning changes to performance/signature and performance/datum since the returned data is designed to be accessed by hash key.

If signature_hash can be replaced then the compare view 'graph' and comparesubtest view 'replicate' urls should also replace the signature_hash query param with signature_id (currently PerformanceDatum has 'id', PerformanceSignature has 'signature_id').

Comment 1

[Ionuț Goldan [:igoldan]]

Dave, this is basically technical dept that should be addressed at some point. Benefits of this mean some query time improvements + cleaner code to reason about.

I'd mark this as P3.

Comment 2

[Ionuț Goldan [:igoldan]]

Maybe we can resume this at the end of Q3?

Comment 3

[Sarah Clements [:sclements]]

This was one of the tasks I wasn't able to complete as part of the conversion - there's still usage in the UI that's been carried over.