1519317 - Shaka Player demo shows MEDIA.VIDEO_ERROR on loop enabled

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

[Affected versions]:

• 66.0a1 (20190110093854)
• 65.0b10 (20190110221328)

[Affected platforms]:

• Windows 10 x64
• macOS 10.13
• Ubuntu 16.04 x86

[Steps to reproduce]:

1. Go to http://goo.gl/0cVfha
2. Right click on the video and enable the Loop option
3. Observe the behavior once the demo is finished

[Expected result]:

• The demo plays again.

[Actual result]:

• “Shaka Error MEDIA.VIDEO_ERROR (3,,NS_ERROR_DOM_MEDIA_WAITING_FOR_DATA (0x806e0009))” error message is displayed.

[Regression range]:

• Last good revision: 06dea9e0cd50794679bbefb51776c8e621e64a98
  First bad revision: 93cfc552f067c2f3a2f888d3d8e0c206671b3f6a
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=06dea9e0cd50794679bbefb51776c8e621e64a98&tochange=93cfc552f067c2f3a2f888d3d8e0c206671b3f6a

[Additional Notes]:

• This issue was encountered as part of Widevine feature testing, affected version 4.10.1146 and 4.10.1196.
• No other demo has this behavior.
• I couldn’t reproduce the issue on Fx releases (64.0 - 20181205213546 and 64.0.2 -20190108160530).
• See the Browser console content when the error is triggered: https://drive.google.com/open?id=1dyq0f2K0XrAD2Sh4LamkV3IV1WsN6Uqk

Comment 1

[Anca Soncutean, Desktop QA]

I forgot to mention the demo, on which the bug is reproducible: "Dig the Uke" by Stefan Kartenberg (audio only, multicodec, Widevine - https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/dig-the-uke/dash.mpd;lang=en-US;build=uncompiled.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Shaka player bustage doesn't sound good. We've got our final 65 Beta build tomorrow before next week's RC. Nils, can you help make sure we get an owner assigned ASAP?

Comment 3

[Alastor Wu [:alwu]]

I'll start to take a look today, sorry for the delay.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1519317 - handle non decoding errors when we seek back to the start position.

'NS_ERROR_DOM_MEDIA_WAITING_FOR_DATA' and 'NS_ERROR_DOM_MEDIA_CANCELED' are not the decoding error, so we should
also treat them specially like what we did for 'NS_ERROR_DOM_MEDIA_END_OF_STREAM'.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

NI jya for the question pending in Phabricator. This feels like a regression we don't want to ship in Fx65, but we're building the RC on Monday... :\

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/413e705328be
handle non decoding errors when we seek back to the start position. r=jya

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 9036991 [details]
Bug 1519317 - handle non decoding errors when we seek back to the start position.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498440

User impact if declined: Shaka player won't be able to replay

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Reproduce steps is mentioned in comment0.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It doesn't introduce any new feature and logic, what we do here is not to return error and handle it properly so that the video can be replay again.

String changes made/needed: no

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Anca, please verify that this is working as expected for you in Nightly builds containing the fix. Thanks!

Comment 9

[Anca Soncutean, Desktop QA]

I can confirm the fix with Fx 66.0a1 - 20190122232941 on Ubuntu 18.04 x64, macOS 10.13 and Windows 10 x64. Note that for Windows, I used the debug build, since the rest of the provided builds for this OS have the usercancel tag.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/413e705328be

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9036991 [details]
Bug 1519317 - handle non decoding errors when we seek back to the start position.

[Triage Comment]
Fixes a regression in the widely-used Shaka Player library. Approved for 65.0 RC2.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/9e7348e493af

Comment 13

[Anca Soncutean, Desktop QA]

This issue is verified as fixed with Fx 65.0 (20190124174741) and Fx 66.0a1 (20190125095457) on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.