1519342 - The Onboarding card is displayed immediately after the 'Add to Firefox' button is selected

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Alexandra Moga [:LexaSV]]

Attachment: onboarding card.mov

[Platform]:

• MacOS 10.13.6

[Application]:

• Nightly 66.0a1

[Steps to reproduce]

1. Go to about:config and set the 'browser.newtabpage.activity-stream.asrouter.devtoolsEnabled' to True
2. Open about:newtab#asrouter, scroll to the bottom of the page and press the 'Force Attribution' button
3. Open about:welcome and click on Add to Firefox button to install the extension

[Actual result]
User is redirected to the Onboarding card before confirming the installation (Add/Cancel) in the doorhanger

[Expected result]
According to the specs, the user should first confirm the installation and only then the redirection to the Onboarding card should happen

Notes:

• please refer to the attachments in this bug for a visual representation of the issue

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4695

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4870c83e3ca145afbf746c73c7c2a856e48f87c4
Bug 1519342 - Show Onboarding card after RTAMO addon install (#4695)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9fb96d1b0b37

Comment 4

[Alexandra Moga [:LexaSV]]

Verified fixed with Nightly 67.0a1 and Beta 66.0b3 on Win10x64 and MacOS High Sierra 10.13.6

Comment 5

[Alexandra Moga [:LexaSV]]

Attachment: 2019-02-01_15-55-46.gif