Closed Bug 1519369 Opened 7 months ago Closed 27 days ago

Can no longer use --jsdebugger with ./mach test

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jdescottes, Assigned: egao)

References

(Regressed 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

When using --jsdebugger with ./mach test, the command logs

Debugger must be specified with '=' when invoking ./mach test.

https://searchfox.org/mozilla-central/rev/b4ebbe90ae4d0468fe6232bb4ce90699738c8125/python/mach/mach/main.py#483-492

I suppose this check was added for the "debugger" argument and is wrongly matching and throwing for "jsdebugger"?

I know there was some work done in 1517811 that supersedes my changes in 1504550. Could you try pulling most recent m-c changes and see if that resolves the issue?

I went ahead and using the current tip, ran the following:

./mach test mochitest --jsdebugger

was able to reproduce the issue:

egao-44538:mozilla-central egao$ ./mach test mochitest --jsdebugger
Debugger must be specified with '=' when invoking ./mach test.
Please correct the command and try again.
egao-44538:mozilla-central egao$
Attached file Bug 1519369 - mach debugger refactor (obsolete) —
  • add jsdebugger to false positive list
Assignee: nobody → egao
Status: NEW → ASSIGNED
Attachment #9045729 - Attachment is obsolete: true

I have what I believe is a much better solution.

It adds the --debugger argument to the mach test command provider (it has been lacking the --debugger that explicit test harness command providers such as mochitest and wpt have).

The presence of --debugger argument in the parsed Namespace object can then be used to determine if the debugger is installed on system.

Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f5855a307b0
support 'debugger' parser argument for mach test command r=ahal,gbrown

Thank you so much for working on this, your fix works perfectly!

Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1573585
You need to log in before you can comment on or make changes to this bug.