1519369 - Can no longer use --jsdebugger with ./mach test

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Julian Descottes [:jdescottes]]

When using --jsdebugger with ./mach test, the command logs

Debugger must be specified with '=' when invoking ./mach test.

https://searchfox.org/mozilla-central/rev/b4ebbe90ae4d0468fe6232bb4ce90699738c8125/python/mach/mach/main.py#483-492

I suppose this check was added for the "debugger" argument and is wrongly matching and throwing for "jsdebugger"?

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

I know there was some work done in 1517811 that supersedes my changes in 1504550. Could you try pulling most recent m-c changes and see if that resolves the issue?

Comment 2

[Edwin Takahashi (:egao | infrequent contributor)]

I went ahead and using the current tip, ran the following:

./mach test mochitest --jsdebugger

was able to reproduce the issue:

egao-44538:mozilla-central egao$ ./mach test mochitest --jsdebugger
Debugger must be specified with '=' when invoking ./mach test.
Please correct the command and try again.
egao-44538:mozilla-central egao$

Comment 3

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1519369 - mach debugger refactor

• add jsdebugger to false positive list

Comment 4

[Edwin Takahashi (:egao | infrequent contributor)]

Try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b508ea4c5f656369a0e4afcbb5eb65e3abbce9c

Comment 5

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1519369 - support 'debugger' parser argument for mach test command

Comment 6

[Edwin Takahashi (:egao | infrequent contributor)]

I have what I believe is a much better solution.

It adds the --debugger argument to the mach test command provider (it has been lacking the --debugger that explicit test harness command providers such as mochitest and wpt have).

The presence of --debugger argument in the parsed Namespace object can then be used to determine if the debugger is installed on system.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f5855a307b0
support 'debugger' parser argument for mach test command r=ahal,gbrown

Comment 8

[Julian Descottes [:jdescottes]]

Thank you so much for working on this, your fix works perfectly!

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2f5855a307b0